572077 - TM: Enabling the request model asserts in optimized builds,

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

The conservative native stack GC scanner from the bug 516832 assumes that the request model is followed to the letter and enforces that with extra asserts. But those are only enabled in the debug builds and, for example, would not present in nighties. Thus the idea is to activate the corresponding asserts in optimized builds for some time to get more test coverage. It should not negatively affect the performance as the asserts are not on the fast paths.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Is this going to make beta3?

Comment 2

[Igor Bukanov]

(In reply to comment #1)
> Is this going to make beta3?

No: It turned out the are better ways to check for conservative GC assumptions, see, for example, bug 581919 and bug 580578. So I would like to see those in beta3.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

So should this be RESO WONTFIX? I adjusted the flags on those other two bugs.

Comment 4

[Igor Bukanov]

(In reply to comment #3)
> So should this be RESO WONTFIX? I adjusted the flags on those other two bugs.

This is indeed WONTFIX. I have found that the corresponding asserts in optimized would not provide better coverage. It is vastly better to simply add more asserts.