Closed
Bug 580578
Opened 14 years ago
Closed 14 years ago
asserting that autorooters are used only under a request
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: igor, Assigned: igor)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
3.67 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
When working on the bug 574313 I have found at least two places in the code where autorooters were used outside the request. The attached patch fixes that and adds an assert to check for a request in the autorooter constructor and destructor.
Attachment #458976 -
Flags: review?(mrbkap)
|
Assignee | |
Comment 1•14 years ago
|
||
The patch depends on the bug 552266 to avoid checking if there were already requests.
Depends on: 552266
|
||
Updated•14 years ago
|
Attachment #458976 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Updated•14 years ago
|
Assignee: general → igor
|
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/70257f457819 - landed with a wrong bug reference. The message refers to bug 552266 instead of this one.
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•14 years ago
|
||
Igor said he thought this was a better way of doing bug 572077 and asked that it be considered a b3 blocker - Rob? What say you?
blocking2.0: --- → ?
|
||
Updated•14 years ago
|
blocking2.0: ? → betaN+
|
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•