Closed
Bug 57220
Opened 24 years ago
Closed 24 years ago
Link colors don't observe "always use my colors" pref
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
VERIFIED
WORKSFORME
People
(Reporter: BenB, Assigned: attinasi)
Details
<quote src="http://bugzilla.mozilla.org/show_bug.cgi?id=40340"> ------- Additional Comments From Marc Attinasi 2000-10-10 16:00 ------- Setting the link colors and link underlining is not based on the users setting for UseDocumentColors. They are independent settings. Link colors are always the default link colors, and are never forced. In other words, there is no option to 'always use my link colors, ignoring the link colors in the document' like there is with background color and text color. That is why there is no check for UseDocumentColors in SetPrefLinkRules. </quote> I disagree. The UI suggests that this prefs applies to *all* colors in the document. It is important to actually to it this way, because color schemes have the potential to collide (back-/foreground vs. link).
Wasn't this already fixed by the revision to the original patch? I think if we allow "Use document colors" then the rules are not !important, but if the user says "Always use my colors" then the rules are !important. That's right, isn't it?
Reporter | ||
Comment 3•24 years ago
|
||
I didn't check the revision. !important for link colors would be "good enough for now", assuming that are user styles and they override the document's soon.
Summary: Link colors don't observe "aöways use my colors" pref → Link colors don't observe "always use my colors" pref
Comment 4•24 years ago
|
||
Yup, this is 4xp. (speaking as someone who `always use[s] my colors')
Assignee | ||
Comment 5•24 years ago
|
||
David is correct in his comment of 2000-10-18 19:10 - this was already fixed. Did this bug get opened based only on a comment in another bug, without testing the actual functionality on the trunk build? Or, is there still a bug with link colors not being applied correctly? Marking WORKSFORME. See nsPresShell.cpp ver. 3.349, where the fix was made, and also check the trunk build. Also, see bug 56098: that is the one David opened when I checked in the wrong rule for link colors, and which he correctly indicated should honor the 'Ignore Document Colors' pref. If the trunk build does not behave correcly in this regard, feel free to reopen. Bug 40340 is tracking the checkin to the branch, and it has the up-to-date patch with the correct rules.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 6•24 years ago
|
||
attinasi, I filed this bug solely based on your comment, without testing. Sorry that I got it wrong in this case. VFY.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•