572236 - urlbar not focused after mousedown inside editarea and mouseup inside textbox

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Begin a touch (or click) inside the white "urlbar-editarea" hbox but outside the actual textbox (e.g. slightly above or below the text).
2. Drag into the textbox and then raise your finger (or mouse button).

Actual results: Nothing happens.
Expected results: urlbar is focused

It seems to be generally true that "click" is not fired for clicks that start in a container and end in one of its children (although the reverse sometimes works).  See http://people.mozilla.com/~mbrubeck/test/container-click.html for a simple test case.  So we might need to handle this ourselves using mousedown/mouseup events instead of click (and mouseout to cancel).

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch fixes the issue, but it introduces a new one: mouseout to cancel the click does not work if the click starts inside the textbox's html:input.  This is caused by bug 574116.

We might want to land this patch anyways, since failing to cancel is not as bad as failing to click (cancelling is the uncommon case), and I haven't found any workaround for this problem.

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to comment #1)
> This patch fixes the issue, but it introduces a new one: mouseout to cancel the
> click does not work if the click starts inside the textbox's html:input.

It turns out this is not a new problem: it happens both with and without the patch.  So the patch fixes this bug without creating any new ones.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: alt patch

Your patch is a bit complex. Can you try this patch instead? It removes the urlbar-editarea and just makes the textbox the right size and style.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 453659 [details] [diff] [review]
alt patch

(In reply to comment #3)
> Your patch is a bit complex. Can you try this patch instead? It removes the
> urlbar-editarea and just makes the textbox the right size and style.

I like this change because it simplifies the code, but it doesn't fix this bug.  The html:input inside of the textbox still does not fill the whole area, and I can still reproduce the bug by pressing outside the html:input and releasing inside it.

I tried expanding the html:input to fill the whole area, but it messes up the positioning of the text.  (Vivien suggested that the vertical position might be fixed with line-height, which I haven't tried yet.  And maybe text-indent could fix the horizontal position.)

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: alt alt patch

This patch works except that the blinking cursor in the textbox is weirdly sized when there is no text.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

We can work on the cursor in a followup. The patch itself looks good and works fine, except for the caret height issue

pushed:
http://hg.mozilla.org/mobile-browser/rev/20b2ce6c2fd5

Comment 7

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110921
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2