[OOPP]Video control does not work while in full screen mode of the flash

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Alice0775 White, Assigned: jimm)

Tracking

({regression})

1.9.2 Branch
x86
Windows 7
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 betaN+, status1.9.2 wanted)

Details

(Whiteboard: [oopp-watchlist] [verify once bug 596094 lands], URL)

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2.4) Gecko/20100611 Firefox/3.6.4 ID:20100611143157
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2.4) Gecko/20100611 Firefox/3.6.4 ID:20100611143157

Fullscreen video controls on http://ve3d.ign.com/videos/69204/PC/Portal-2/Trailer/E3-2010-Debut-Trailer does not work of Firefox 3.6.4 .

If I disabled OOPP, the video contorol works again.

This problem happens also on the following trunk and branch.
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100616 Minefield/3.7a6pre ID:20100616035900
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.6pre) Gecko/20100616 Namoroka/3.6.6pre ID:20100616042232.

Reproducible: Always

Steps to Reproduce:
1. Start Minfield/Namoroka/Firefox3.6.4 with new profile + Flash 10.1
2. Open URL ( http://ve3d.ign.com/videos/69204/PC/Portal-2/Trailer/E3-2010-Debut-Trailer )
3. Play flash movie
4. Click full screen icon  of the flash video.
5. Click video controls.

Actual Results:
 Video control does not work while in fullscreen mode of the flash video

Expected Results:
 Video control should work while in fullscreen mode of the flash video
(In reply to comment #0)
> This problem happens also on the following trunk and branch.
> Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre)
> Gecko/20100616 Minefield/3.7a6pre ID:20100616035900

actually it doesn't work back in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1) Gecko/20100208 MozillaDeveloperPreview/3.7a1 (http://hg.mozilla.org/mozilla-central/rev/43e818c28059; setting dom.ipc.plugins.enabled;true manually) either.

Comment 2

7 years ago
Build worked : 
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4pre) Gecko/20100406 Namoroka/3.6.4pre

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/965a31dcde02

Build broken : 
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4pre) Gecko/20100407 Lorentz/3.6.4pre

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ec534329e186

Pushlog : 
http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?fromchange=965a31dcde02&tochange=ec534329e186

Updated

7 years ago
Whiteboard: [oopp-watchlist]

Comment 3

7 years ago
...which basically points to OOPP, as that's when it landed

Updated

7 years ago
Assignee: nobody → jmathies
(Reporter)

Comment 4

7 years ago
In adittion comment #0
In fullscreen mode, 
Right click on flash video does not work. should popup flash context menu. 
Left click on flash video  does not work. should toggle pause and play.

Comment 5

7 years ago
(In addition to comment #0 and comment #4)
http://video.xnxx.com/video435366/perfect_ass_and_videogames
Excuse me for an example :)
If click fullscreen button - bug, and only ESC helps,
but if MENU-fullscreen - no bug!

Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6
With two last stable flash player versions.
(Assignee)

Updated

7 years ago
blocking2.0: --- → ?

Updated

7 years ago
blocking2.0: ? → betaN+
(Assignee)

Comment 6

7 years ago
(In reply to comment #5)
> (In addition to comment #0 and comment #4)
> http://video.xnxx.com/video435366/perfect_ass_and_videogames
> Excuse me for an example :)
> If click fullscreen button - bug, and only ESC helps,
> but if MENU-fullscreen - no bug!
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.9.2.6) Gecko/20100625
> Firefox/3.6.6
> With two last stable flash player versions.

note - nsfw ^^^
(Assignee)

Comment 7

7 years ago
Appears to be a window activation problem, mouse events are being delivered to the underlying plugin window.
(Assignee)

Updated

7 years ago
Depends on: 596094
(Assignee)

Comment 8

7 years ago
Created attachment 478865 [details] [diff] [review]
fix for event race v.1
(Assignee)

Updated

7 years ago
Attachment #478865 - Attachment is obsolete: true
(Assignee)

Comment 9

7 years ago
Created attachment 479517 [details]
stand alone test case
(Assignee)

Comment 10

7 years ago
Created attachment 479586 [details] [diff] [review]
rel capture patch

Makes sure capture is released after the mouse is released.
(Assignee)

Updated

7 years ago
Attachment #479586 - Flags: review?(benjamin)
(Assignee)

Comment 11

7 years ago
Comment on attachment 479586 [details] [diff] [review]
rel capture patch

Doh, that should be the up events!
Attachment #479586 - Flags: review?(benjamin)
(Assignee)

Comment 12

7 years ago
Created attachment 479679 [details] [diff] [review]
rel capture patch
Attachment #479586 - Attachment is obsolete: true
Attachment #479679 - Flags: review?(benjamin)
Comment on attachment 479679 [details] [diff] [review]
rel capture patch

Do we need to do this in-process as well, or is this just something peculiar to multiple processes and capture?
Attachment #479679 - Flags: review?(benjamin) → review+
(Assignee)

Comment 14

7 years ago
http://hg.mozilla.org/mozilla-central/rev/e05eb865c779
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 15

7 years ago
This is still not fixed on Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101011 Firefox/4.0b8pre

Setting dom.ipc.plugins.enabled to true and controls etc. work in fullscreen.

Updated

7 years ago
status1.9.2: --- → wanted
(Assignee)

Comment 16

7 years ago
(In reply to comment #11)
> Comment on attachment 479586 [details] [diff] [review]
> rel capture patch
> 
> Doh, that should be the up events!

Oh man, I may have made a short sighted last minute change that broke this. Will test and post back.
(Assignee)

Comment 17

7 years ago
(In reply to comment #16)
> (In reply to comment #11)
> > Comment on attachment 479586 [details] [diff] [review] [details]
> > rel capture patch
> > 
> > Doh, that should be the up events!
> 
> Oh man, I may have made a short sighted last minute change that broke this.
> Will test and post back.

Actually, this depends on our sub classes being in place (bug 596094). When I wrote this I had those patches applied underneath. We have to wait for those to land before we can verify this bug is fixed.
(Assignee)

Updated

7 years ago
Whiteboard: [oopp-watchlist] → [oopp-watchlist] [verify once bug 596094 lands]
Created attachment 485201 [details]
Browser window context menus instead of flash ones

Jim, I just tried the hourly (20101021160721 e5f3177aa3bc) with the subclass fix, but didn't see any improvement here.  I can get the browser context menus to show up if I click enough times (see attachment) but not flash's context menu, nor can I use the left to manipulate the controls.  OOPP enabled.
(Assignee)

Comment 19

7 years ago
Are you sure you grabbed the right hourly? Working here for me:

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1287702441/
(Assignee)

Comment 20

7 years ago
(In reply to comment #19)
> Are you sure you grabbed the right hourly? Working here for me:
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1287702441/

ah crap, sorry, I had ipc disabled. You're right, this still isn't working.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 21

7 years ago
Odd, in a local debug build this is working fine. Must be something with the timing. I'll see if I can track this down tomorrow.
(Assignee)

Comment 22

7 years ago
(In reply to comment #21)
> Odd, in a local debug build this is working fine. Must be something with the
> timing. I'll see if I can track this down tomorrow.

Ok, now in today's nightly it appears to be fixed again!
(Assignee)

Comment 23

7 years ago
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101022 Firefox/4.0b8pre
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
This is still not working as expected using a Build built from http://hg.mozilla.org/mozilla-central/rev/2842d671052f (Hourly) + Adobe Flash 10.2.161.23 on WinXP.

Comment 25

7 years ago
(In reply to comment #24)
> This is still not working as expected

same for me, it's still not working
(Assignee)

Comment 26

7 years ago
(In reply to comment #25)
> (In reply to comment #24)
> > This is still not working as expected
> 
> same for me, it's still not working

What's the version of fx you're testing with?

Comment 27

7 years ago
(In reply to comment #26)
> What's the version of fx you're testing with?

sorry, it is: latest-trunk nightly with Adobe Flash 10.1.85.3 on Win Vista / Win7 x86
(Assignee)

Comment 28

7 years ago
So what steps are people taking here?  My STR:

1) visit http://ve3d.ign.com/videos/69204/PC/Portal-2/Trailer/E3-2010-Debut-Trailer
2) click through the ad to the video
3) click full screen button on the video
4) click full screen button in the full screen video

or

3) click play
4) click full screen button on the video
5) click full screen button in the full screen video

In both cases the full screen button in step five closes the full screen window.

Is there any variation here for those that still see this?

Comment 29

7 years ago
(In reply to comment #28)

none of the video controls is working as soon as I am in full screen mode.

Something I just found out:
1.: video is in fullscreen mode (stand alone testcase)
2.: - right clicking upper part of the video: tabs context menu appears
and / or
- right clicking right part of the video: website context menu shows up (clicking at the position where those normally would have shown up in non-fullscreen mode, menus will not disappear)
3.: after one of that, I can do a right click on the top of the screen: firefox window menu appears (minimize, close etc...)
4.: then video controls are working fine, previous menus will disappear, right click brings up flashplayer menu!
(In reply to comment #28)
> So what steps are people taking here?  My STR:

Regarding Comment 24 I used the one of Comment 0.

Comment 31

7 years ago
Note that this is still not fixed for me, but what I described in comment #29 can be shortened now since the landing of bug 595132:

1: firefox is maximized, video is in full screen mode (stand alone testcase)
2: right click top of the screen: firefox window menu appears (minimize, close etc...)
3: clicking in fullscreen flash only then totally works as expected

It just feels as if the firefox window is still in the foreground (although you can only see the fullscreen flash) as I can easily open different types of browser context menus (though I am not able to click on the menus then).
(Assignee)

Comment 32

6 years ago
I finally managed to reproduce this again in a vmware image. Will dig into this more today.
(Assignee)

Comment 33

6 years ago
Created attachment 497879 [details] [diff] [review]
move release after CallWindowProc patch

Just pushed this to try to get a release build for testing. This fixed the problem in my vmware image.
(Assignee)

Comment 34

6 years ago
(In reply to comment #33)
> Created attachment 497879 [details] [diff] [review]
> move release after CallWindowProc patch
> 
> Just pushed this to try to get a release build for testing. This fixed the
> problem in my vmware image.

http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/jmathies@mozilla.com-3def17b8a4b8/try-w32/

I'd appreciate anyone who can reproduce this reliable take this build for a spin and see if they still see the problem.

Comment 35

6 years ago
(In reply to comment #34)
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/jmathies@mozilla.com-3def17b8a4b8/try-w32/
> 
> I'd appreciate anyone who can reproduce this reliable take this build for a
> spin and see if they still see the problem.

It is working fine!
(Assignee)

Comment 36

6 years ago
Comment on attachment 497879 [details] [diff] [review]
move release after CallWindowProc patch

This is slight change from the original patch. Reset the capture state after the mouse event is delivered.
Attachment #497879 - Flags: review?(benjamin)
Comment on attachment 497879 [details] [diff] [review]
move release after CallWindowProc patch

While you're here, add a space after `switch`
Attachment #497879 - Flags: review?(benjamin) → review+
(Assignee)

Comment 38

6 years ago
http://hg.mozilla.org/mozilla-central/rev/39aba38b8706
Indeed, it's fixed now for real with Firefox/4.0b9pre ID:20101220150506. Thanks Jim :)
(Assignee)

Updated

6 years ago
Depends on: 628872
(Reporter)

Updated

6 years ago
Depends on: 634216
You need to log in before you can comment on or make changes to this bug.