Closed
Bug 572436
Opened 15 years ago
Closed 15 years ago
Get rid of app-specific hacks (switch (Svc.AppInfo.ID)) in sync library
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
1.4
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.27 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
There are a few cases where we have app-specific code in the sync library. Ideally these would be moved to default preferences in the corresponding app glue packages. For the add-on case we could set the default preference programmatically.
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → philipp
|
|
Assignee | |
Comment 1•15 years ago
|
||
Set relevant default preferences programmatically in app specific overlays, making app-specific code paths in the sync library unnecessary.
I'm not entirely happy with having to import utils.js now, but if we go through Weave.Service again we trigger Weave.Service.onStartup and thus _registerEngines before having set the default prefs.
Attachment #451684 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Rebased patch on tip after s/weave/services-sync/ (bug 570636) was landed.
Attachment #451684 -
Attachment is obsolete: true
Attachment #451729 -
Flags: review?(mconnor)
Attachment #451684 -
Flags: review?(mconnor)
|
|
||
Updated•15 years ago
|
Attachment #451729 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Updated•15 years ago
|
Blocks: 571902
Keywords: checkin-needed
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/services/fx-sync/rev/e5bce5ae1712
Set relevant default preferences programmatically in app specific overlays, making app-specific code paths in the sync library unnecessary.
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4
|
|
||
Updated•15 years ago
|
Flags: blocking-fx-sync1.4+
|
||
Updated•7 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•