572666 - Add or Edit Contact Dialog won't close or update details (aDatepicker.yearField is null)

Status: RESOLVED WORKSFORME

(Thunderbird :: Address Book, defect)

Description

[Nick]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 ( .NET CLR 3.5.30729; .NET4.0C)
Build Identifier: 3.0.4

When in the address book and either adding or editing a contact, the dialog displays fine. However after the details have been entered, clicking "OK" does nothing & the dialog box does not close. The only way to close the dialog is by 
selecting "Cancel" or the "X" in the top right of the dialog.

If the action is edits to an existing contact then the changes do seem to be applied, but if the edit is to add a new contact it is not added.



Reproducible: Always

Steps to Reproduce:
1. Open Address Book
2. Click "New Contact" (or Edit existing contact)
3. Make amends and click "OKAY"
4. Nothing happens
5. Click Cancel and dialog closes (New contact info lost, but existing contact amends applied)
Actual Results:  
As per details section

Expected Results:  
Clicking "OK" should close the dialog and either add the new contact or apply the edits to existing contacts

I have removed all trace of TB and done a clean reinstall however the issue still remains.

On the Get Satisfaction site others have this issue and it may (possibly) be issue with Win 7 64 bit?

At the moment if I want to add a brand new contact I have had to install syncing with my Google Contacts and add the contact in Google. It will then sync into TB okay.

Comment 1

[[:Aureliano Buendía]]

Nick do you have try also in safe-mode ? (see how-to start TB in
safe-mode here http://support.mozillamessaging.com/en-US/kb/Safe+Mode )

Comment 2

[Nick]

Tried in safe mode - same issue as described above.

Comment 3

[Nathan Rona]

Have the same issue with TB6 

Tried in safe mode. 

Tried to delete the .mab files and have TB recreate them, did not help.

Comment 4

[Nathan Rona]

Checked the error console
When pressing "new contact" these two error messages are added

Error: this.yearField is null
Source File: chrome://global/content/bindings/datetimepicker.xml
Line: 832

Error: aDatepicker.yearField is null
Source File: chrome://messenger/content/addressbook/abCardOverlay.js
Line: 798

Comment 5

[Wayne Mery (:wsmwk)]

Nick, do you see the same messages in error console as Nathan?


Both, does this reproduce with a new profile?
  see https://support.mozillamessaging.com/en-US/kb/Using+Multiple+Profiles

do NOT delete the old profile

Comment 6

[smkozasa]

This bug still happens with Thunderbird 11.0.1 running on Kubuntu Linux 11.10, language Brazilian Portuguese.

Hora: 18-04-2012 12:17:42
Erro: uncaught exception: An error occurred throwing an exception

Hora: 18-04-2012 12:17:42
Erro: aDatepicker.yearField is undefined
Arquivo-fonte: chrome://messenger/content/addressbook/abCardOverlay.js
Linha: 789

Comment 7

[smkozasa]

Still happens with Thunderbird 12.0.1. I made a test using LXDE and the bug persists. I suspect this may be related with my regional configurations (Brazilian Portuguese and speciffically date configurations) and my .mab address book that may be corrupted some way. I can workaround this by clicking on an e-mail address on the header of a message, click to add to address book, then opening the address book and moving the contact to the group I want.

Comment 8

[Vincent GARNIER]

I experienced the same issue ONLY with contacts having a photo. Safe mode included. Other contacts not having a photo are editable as it should be expected, and clicking OK works. I run Thunderbird 14.0.0.4577 on a Windows 7 64-bit system. If that might help.

Comment 9

[smkozasa]

OK, Now I know this is caused by incompatible date / time formats. I've been able to fix (workaround) this changing the launcher icon to:

export LC_TIME="en_US";thunderbird

That is, my location time configurations is pt_BR, this DOES NOT WORK. It works with en_US, but this will make shown date format to be different as local. So a bug fix is required. Can someone please change this to CONFIRMED status, please?

Comment 10

[Thomas D. (:thomas8)]

Confirming per comment 9 and comment 4, which list the same error message.
So we certainly have an issue here.

I'd think smkozasa confirmed this for Linux, I'm not sure if/how that relates to the original bug reported against win7.

smkozasa, can you provide a patch?

Comment 11

[smkozasa]

Though the original bug report was for Win7, I believe it may be a multi-platform issue caused by non-english date / time configurations. I guess it would be very helpful if everybody involved could provide their OS date / time configurations.

If Win7 users could make a test changing date / time format to the one used in the United States could be a confirmation of my hypothesis.

Unfortunatelly I don't do serious programming since 10 or 15 years ago... The closest I can provide as a patch is the workaround in comment 9.

Thanks.

Comment 12

[Vincent GARNIER]

I changed to en_US date / time format but it didn't work.
I confirm that the error (clicking OK doesn't close nor update changes made in a contact) persists ONLY with contacts having a photo defined (from a local directory). Maybe it's a different bug I experience here than the one caused by date / time format.

Using :
Thunderbird 15.0.0.4619
Windows 7 Home Edition Premium 64-bit, Service Pack 1
Local : fr_FR

Comment 13

[Jeff Bloomfield]

I'm still using 60.9.1 (for my own reasons). Bug is not closed. If this is still an issue in the current version, it would be sweet if someone
fixes it (the bug is 13 years old!). Meanwhile, the workaround in Comment #9 is good enough until I get around to updating Tbird.

Comment 14

[Jeff Bloomfield]

Thank you for publishing the workaround!

Comment 15

[Thomas D. (:thomas8)]

(In reply to Jeff Bloomfield from comment #13)

I'm still using 60.9.1 (for my own reasons). Bug is not closed. If this is still an issue in the current version, it would be sweet if someone
fixes it (the bug is 13 years old!). Meanwhile, the workaround in Comment #9 is good enough until I get around to updating Tbird.

Hi Jeff, thanks for the ping.
For Thunderbird 102 (current release version), the address book has been almost completely rewritten, so this bug is no longer applicable. I also remember that we have fixed bugs around using localized or even customized date formats, so that's more flexible and reliable now.
Are you able to share the reasons for staying with 60.9.1? There's tons of improvements and bugfixes from all the new versions of TB which you've missed... For your own peace of mind, I recommend doing a full backup of your TB profile folder before updating.