572716 - Escape does not dismiss SelectHelper popup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Open the Fennec prefs panel and open the "Start page" select popup
2. Press escape

Expected results: popup is dismissed, prefs panel remains.
Actual results:   prefs panel is dismissed, popup remains.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Register SelectHelper as a popup.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Does this cause any interaction problems with Form Assistant (for web page <select>s) ? Do the browser-chrome tests pass?

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 451978 [details] [diff] [review]
patch

This does cause problems with FormAssistant.  (Tests pass, though.)  I'll work on a fix later.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

Fix the problem when showing SelectHelper within FormHelper.

Also fixes an unrelated bug where the SelectHelper popup has messed up height after using FormHelper.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 452093 [details] [diff] [review]
patch v2

Looks good

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/a00bc9d12c65

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a6pre) Gecko/2010621 Namoroka/3.7a6pre Fennec/2.0a1pre