Remove references to chrome://weave from services

RESOLVED FIXED in 1.4

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
blocking-fx-sync1.4 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Utils has helpers like openChromeWindow openDialog openGenericDialog that references chrome://weave

Those will probably need to be refactored into the ui components before landing on trunk?
(Assignee)

Comment 1

8 years ago
Created attachment 452333 [details] [diff] [review]
v1 dialogs
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #452333 - Flags: review?(mconnor)

Updated

8 years ago
Attachment #452333 - Flags: review?(mconnor) → review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/services/fx-sync/rev/26a996c2319d
Remove openWindow/Dialog helpers and inline into ui bits for prefs-common and pass arguments into generic-change.
(Assignee)

Comment 3

8 years ago
Other references:

constants.js: chrome://weave is an opaque token for the password manager
clients.js: chrome://branding is a well-known location
util.js: chrome://weave/locale/services has strings for services that will get similarly registered on trunk as part of jar.mn
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: blocking-fx-sync1.4+
Resolution: --- → FIXED
Target Milestone: --- → 1.4
(Assignee)

Updated

8 years ago
Depends on: 573194
(Assignee)

Updated

8 years ago
Blocks: 573691
You need to log in before you can comment on or make changes to this bug.