573194 - AboutWeaveTabs still references chrome://weave/content/firefox/tabs.xul

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

This page is going to be app specific so shouldn't be hard coded in the service. I'm just patching locally for now to point to chrome://browser/content/sync/tabs.xul

Comment 1

[Mike Connor [:mconnor]]

Really, since this is Firefox specific, we shouldn't register it from the backend... not sure as of this writing what we should do here.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #1)
> Really, since this is Firefox specific, we shouldn't register it from the
> backend... not sure as of this writing what we should do here.

On the Firefox side, I think we've got 3 choices:

* nsBrowserGlue seems to be a new dumping ground for component registration (Geolocation prompt was added there).

* We could add it with the other about:(sessionstore|privatebrowsing|robots|etc) urls in b/c/about/AboutRedirector.cpp and b/c/build/nsModule.cpp (I don't know why AboutRedirector is still a cpp, but whatever).

* We just add another component to browser/components to be that new dumping ground.

On the Weave side, we might want to pull that registration out into a separate file so that nothing has to be done post hg convert, especially since we want to be able to just hg convert and merge.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

I know this should be Firefox only done properly, but this at least separates it out from Weave.js. This means we don't need to change the filemap in bug 571902.

Mardak also pointed out that importing Weave.js probably shouldn't be happening in the component like it is. Followup?

Comment 4

[Ed Lee :Mardak]

Comment on attachment 452866 [details] [diff] [review]
Patch v0.1

>+++ b/services/sync/components/AboutWeaveTabs.js
>+const Ci = Components.utils;
Ci.import ?! ;)

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/238823924c8b
Split off about: chrome aliasing from other services aliases. 

Oops. Forgot to qref -u to zpao ! :( hg export next time! :)