Closed Bug 573194 Opened 11 years ago Closed 11 years ago

AboutWeaveTabs still references chrome://weave/content/firefox/tabs.xul

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: zpao, Assigned: zpao)

References

Details

Attachments

(1 file)

This page is going to be app specific so shouldn't be hard coded in the service. I'm just patching locally for now to point to chrome://browser/content/sync/tabs.xul
Really, since this is Firefox specific, we shouldn't register it from the backend... not sure as of this writing what we should do here.
(In reply to comment #1)
> Really, since this is Firefox specific, we shouldn't register it from the
> backend... not sure as of this writing what we should do here.

On the Firefox side, I think we've got 3 choices:

* nsBrowserGlue seems to be a new dumping ground for component registration (Geolocation prompt was added there).

* We could add it with the other about:(sessionstore|privatebrowsing|robots|etc) urls in b/c/about/AboutRedirector.cpp and b/c/build/nsModule.cpp (I don't know why AboutRedirector is still a cpp, but whatever).

* We just add another component to browser/components to be that new dumping ground.

On the Weave side, we might want to pull that registration out into a separate file so that nothing has to be done post hg convert, especially since we want to be able to just hg convert and merge.
Attached patch Patch v0.1Splinter Review
I know this should be Firefox only done properly, but this at least separates it out from Weave.js. This means we don't need to change the filemap in bug 571902.

Mardak also pointed out that importing Weave.js probably shouldn't be happening in the component like it is. Followup?
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #452866 - Flags: review?(edilee)
Blocks: 573108
Flags: blocking-fx-sync1.4+
Comment on attachment 452866 [details] [diff] [review]
Patch v0.1

>+++ b/services/sync/components/AboutWeaveTabs.js
>+const Ci = Components.utils;
Ci.import ?! ;)
Attachment #452866 - Flags: review?(edilee) → review+
http://hg.mozilla.org/services/fx-sync/rev/238823924c8b
Split off about: chrome aliasing from other services aliases. 

Oops. Forgot to qref -u to zpao ! :( hg export next time! :)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.