Last Comment Bug 573278 - Port |Bug 522252 - make archiving of read-only folders do a copy, not a move| to SeaMonkey
: Port |Bug 522252 - make archiving of read-only folders do a copy, not a move|...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: MailNews: Backend (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a2
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-19 15:57 PDT by Jens Hatlak (:InvisibleSmiley)
Modified: 2010-06-19 17:26 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.19 KB, patch)
2010-06-19 15:57 PDT, Jens Hatlak (:InvisibleSmiley)
no flags Details | Diff | Review
patch with comment updates [Checkin: comment 3] (2.39 KB, patch)
2010-06-19 16:48 PDT, Jens Hatlak (:InvisibleSmiley)
mnyromyr: review+
mnyromyr: superreview+
Details | Diff | Review

Description Jens Hatlak (:InvisibleSmiley) 2010-06-19 15:57:06 PDT
Created attachment 452500 [details] [diff] [review]
patch

From bug 522252:
"Archiving of news messages attempts to do a move to the archive folder, which
only half succeeds (the copy part succeeds, the delete after fails). This
leaves the destination folder locked. We should make archive of newsgroups or
other folders that don't allow deleting of messages to do a copy, not a move."

I think this could be a MOA case, thus requesting r+sr at the same time.
Comment 1 Jens Hatlak (:InvisibleSmiley) 2010-06-19 16:48:33 PDT
Created attachment 452504 [details] [diff] [review]
patch with comment updates [Checkin: comment 3]

While we're here we could just as well add some comments about why and how we're implementing functions from the listeners used, and group what belongs together. The choice is yours. :-)
Comment 2 Karsten Düsterloh 2010-06-19 17:21:05 PDT
Comment on attachment 452504 [details] [diff] [review]
patch with comment updates [Checkin: comment 3]

r/moa=me
Comment 3 Jens Hatlak (:InvisibleSmiley) 2010-06-19 17:26:21 PDT
Comment on attachment 452504 [details] [diff] [review]
patch with comment updates [Checkin: comment 3]

http://hg.mozilla.org/comm-central/rev/42d7e1d26ef4

Note You need to log in before you can comment on or make changes to this bug.