573326 - In the toolbar customization window, hide the toolbarbutton label and replicate it on the wrapper

Status: RESOLVED FIXED

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

See for example bug 559033 comment 19.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 452535 [details] [diff] [review]
v1

What's the goal here?

I can see the value if we're changing the default state of toolbarbuttons on mac to not include the text, but there doesn't seem to be much benefit to doing that separately and ahead of time, since it requires the change to customizeToolbar.css to preserve the current behavior.

Comment 2

[Markus Stange [:mstange]]

The goal is to be able to put borders around the toolbarbuttons in the customize panel and have the label outside that border.
This patch alone won't change anything visually. I need to make a separate patch that actually sets the border on the buttons there.

This is completely independent of the decision about what to do for buttons in toolbars in icon/text mode.

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> This patch alone won't change anything visually.

It will, on Windows.

Comment 4

[Markus Stange [:mstange]]

Oh, indeed! Will that make things better or worse? I guess the inconsistency with the look of the toolbar in icons/text mode makes it worse... but then again, we don't really care.

Comment 5

[Dão Gottwald [:dao]]

It should make things better.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/c49f902c4a23