Closed Bug 573382 Opened 10 years ago Closed 10 years ago

No chrome package registered for chrome://inspector/content/tasksOverlay.xul

Categories

(Toolkit :: Startup and Profile System, defect, major)

x86
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla2.0b2
Tracking Status
blocking-seamonkey2.1 --- a3+

People

(Reporter: mnyromyr, Assigned: Callek)

References

Details

Attachments

(1 file, 4 obsolete files)

When starting SeaMonkey trunk¹ with builtin DOMI, the DOMI entry in Tools->Web Development is missing. 

Error console says:
-------------------------------------------------------------------------
Warning: Warning: Unrecognized chrome registration modifier 'xpcnativewrappers=no'.
Source File: file:///home/kd/projekte/mozilla/mozilla.org/obj/sr/mozilla/dist/bin/extensions/inspector@mozilla.org/chrome.manifest
Line: 19

No chrome package registered for chrome://inspector/content/tasksOverlay.xul

Warning: Failed to load overlay from chrome://inspector/content/tasksOverlay.xul.
Source File: chrome://messenger/content/messenger.xul
Line: 0
-------------------------------------------------------------------------

DOMI won't work even if started manually, since chrome://inspector/content/inspector.xul isn't registered either.



¹ Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a6pre) Gecko/20100620 SeaMonkey/2.1a2pre
Blocks: 567094
OK, so is there _any_ way to have an xpcnativewrappers=no package on trunk (with the modifier just ignored) and on branches?  If not, it sounds like we need two separate inspector XPIs....
Since on trunk xpcnativewrappers is always on, why can't trunk just totally ignore this flag i.e. treat it as a NOOP?
That's my question, yes.
SeaMonkey test_idcheck.xul was failing due to this; (couldn't open the window, therefore was not understanding that the window closed);

Disabled that part of the test in http://hg.mozilla.org/comm-central/rev/3a70e023b8a3
Blocks: 533592
(In reply to comment #4)
> Disabled that part of the test in
> http://hg.mozilla.org/comm-central/rev/3a70e023b8a3

and correctly in: http://hg.mozilla.org/comm-central/rev/24bcb8811f93
I decided to keep a warning message for this, though modified to actually indicate the truth. (Its not technically "unrecognized" anymore)
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #452656 - Flags: review?(bzbarsky)
...and qref before attaching.
Attachment #452656 - Attachment is obsolete: true
Attachment #452657 - Flags: review?(bzbarsky)
Attachment #452656 - Flags: review?(bzbarsky)
bz, I'd love if this could land before SeaMonkey's official freeze later today. So a faster review is VERY appreciated.
Attachment #452657 - Attachment is obsolete: true
Attachment #453021 - Flags: review?(bzbarsky)
Attachment #452657 - Flags: review?(bzbarsky)
Marking blocking; assuming my testing goes good we can avoid this holding up the release even if its not reviewed by landing on relbranch, even with that being a PITA.
blocking-seamonkey2.1: --- → a2+
Attachment #453021 - Flags: review?(bzbarsky) → review?(benjamin)
I landed attachment 453021 [details] [diff] [review] as http://hg.mozilla.org/mozilla-central/rev/f6cf82daa5bd on COMM193a5_20100623_RELBRANCH so we could spin the SeaMonkey 2.1a2 with a working DOM inspector.

This means it's now "only" blocking DOMI usage on trunk, but not the 2.1a2 release.
I'm fine with this in principle, but I don't want to take it until bug 568691 lands to avoid merge conflicts.
blocking-seamonkey2.1: a2+ → a3+
That landed.  Can we get this reviewed and in so Inspector works again on trunk?
Component: DOM Inspector → Startup and Profile System
Product: Other Applications → Toolkit
QA Contact: dom-inspector → startup
Comment on attachment 453021 [details] [diff] [review]
Allow xpcnativewrappers to not fail-out on trunk (v2)

...needs updating since e10s and the ChromeRegistration changes that just landed, I'll tackle it tomorrow.
Attachment #453021 - Flags: review?(benjamin) → review-
This is basically the same patch, but it moved files and is adjusted for bitrot; I did correct a few whitespace nits of my own in the area where I am patching as well.
Attachment #453021 - Attachment is obsolete: true
Attachment #456003 - Flags: review?(benjamin)
Choosing Mossop as a reviewer since he said he could tackle this during his trip on tuesday, if ben didn't beat him to it.
Attachment #456003 - Attachment is obsolete: true
Attachment #456132 - Flags: review?(dtownsend)
Attachment #456003 - Flags: review?(benjamin)
Comment on attachment 456132 [details] [diff] [review]
Allow xpcnativewrappers to not fail-out on trunk (v4) [Checked in: Comment 17]

Looks good
Attachment #456132 - Flags: review?(dtownsend) → review+
Comment on attachment 456132 [details] [diff] [review]
Allow xpcnativewrappers to not fail-out on trunk (v4) [Checked in: Comment 17]

http://hg.mozilla.org/mozilla-central/rev/735cd721df02
Attachment #456132 - Attachment description: Allow xpcnativewrappers to not fail-out on trunk (v4) → Allow xpcnativewrappers to not fail-out on trunk (v4) [Checked in: Comment 17]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to comment #5)
> (In reply to comment #4)
> > Disabled that part of the test in
> > http://hg.mozilla.org/comm-central/rev/3a70e023b8a3
> 
> and correctly in: http://hg.mozilla.org/comm-central/rev/24bcb8811f93

Then, can the test be reenabled now ?
Target Milestone: --- → mozilla2.0b2
(In reply to comment #18)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Disabled that part of the test in
> > > http://hg.mozilla.org/comm-central/rev/3a70e023b8a3
> > 
> > and correctly in: http://hg.mozilla.org/comm-central/rev/24bcb8811f93
> Then, can the test be reenabled now ?

rs+=me if anyone wants to push a test re-enable for this.
(In reply to comment #19)
> > Then, can the test be reenabled now ?
> 
> rs+=me if anyone wants to push a test re-enable for this.

Pushed as http://hg.mozilla.org/comm-central/rev/0315482debe4
You need to log in before you can comment on or make changes to this bug.