533592 - Get rid of xpcnativewrappers=no

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

In order to make the decision "what type of wrapper should I create for this object?" depend only on the scope we're looking at and the object (and its scope), we need to do this.

Comment 1

[Shawn Wilsher :sdwilsh]

What is the alternative for add-on authors then?

Comment 2

[Boris Zbarsky [:bzbarsky]]

xpcnativewrappers=no was a temporary measure to allow addons to transition to using .wrappedJSObject in the places where they really needed to examine expando properties.  If any haven't done so by now, they should.

Comment 3

[Jason Orendorff [:jorendorff]]

Getting rid of this will allow us to get rid of the BYPASS code in XPCNativeWrapper.cpp, which is necessary for compartmentalization. Taking.

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Part 1, get rid of xpcnativewrappers=foo - v1

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Part 2, get rid of bypass - v1

Comment 6

[Jason Orendorff [:jorendorff]]

Ran these through Try Server along with the patches in bug 568379, and it came back beautifully green. :)

Comment 7

[Jason Orendorff [:jorendorff]]

Part 1: http://hg.mozilla.org/tracemonkey/rev/1bc36f4d8ea3
Part 2: http://hg.mozilla.org/tracemonkey/rev/8c42fc73321a

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/1bc36f4d8ea3

Comment 9

[Nickolay_Ponomarev]

For the reference: http://blog.mozilla.com/mrbkap/2010/02/11/xpcnativewrappersno-going-away/

I mentioned this bug at https://developer.mozilla.org/en/Chrome_Registration#xpcnativewrappers for now. Ideally we'd have a migration guide.

Comment 10

[Eric Shepherd [:sheppy]]

Added a note to the XPCOM changes in Firefox 4 page:

https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_2.0#XPCNativeWrapper_changes

Can anyone explain to me exactly how someone would go about updating their code? I have no clue where to even start here.

Comment 11

[Eric Shepherd [:sheppy]]

I transcribed info from mrbkap's blog post to the XPCOM changes in Gecko 2.0 page, but we could still use a good step-by-step migration guide.

Comment 13

[Eric Shepherd [:sheppy]]

Updated more stuff, calling this done.