Get rid of xpcnativewrappers=no

RESOLVED FIXED in mozilla1.9.3a5

Status

()

Core
DOM
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: mrbkap, Assigned: jorendorff)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.3a5
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(fixed-in-tracemonkey)

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
In order to make the decision "what type of wrapper should I create for this object?" depend only on the scope we're looking at and the object (and its scope), we need to do this.
What is the alternative for add-on authors then?
Blocks: 533599
xpcnativewrappers=no was a temporary measure to allow addons to transition to using .wrappedJSObject in the places where they really needed to examine expando properties.  If any haven't done so by now, they should.
No longer blocks: 533599
Depends on: 533599
(Reporter)

Updated

7 years ago
Blocks: 515496
(Assignee)

Comment 3

7 years ago
Getting rid of this will allow us to get rid of the BYPASS code in XPCNativeWrapper.cpp, which is necessary for compartmentalization. Taking.
Assignee: nobody → jorendorff
Blocks: 563106
OS: Linux → All
Hardware: x86 → All
(Assignee)

Comment 4

7 years ago
Created attachment 447716 [details] [diff] [review]
Part 1, get rid of xpcnativewrappers=foo - v1
Attachment #447716 - Flags: review?(mrbkap)
(Assignee)

Comment 5

7 years ago
Created attachment 447717 [details] [diff] [review]
Part 2, get rid of bypass - v1
Attachment #447717 - Flags: review?(mrbkap)
(Reporter)

Updated

7 years ago
Attachment #447716 - Flags: review?(mrbkap) → review+
(Reporter)

Updated

7 years ago
Attachment #447717 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 6

7 years ago
Ran these through Try Server along with the patches in bug 568379, and it came back beautifully green. :)
(Assignee)

Comment 7

7 years ago
Part 1: http://hg.mozilla.org/tracemonkey/rev/1bc36f4d8ea3
Part 2: http://hg.mozilla.org/tracemonkey/rev/8c42fc73321a
Whiteboard: fixed-in-tracemonkey

Updated

7 years ago
Keywords: dev-doc-needed

Comment 8

7 years ago
http://hg.mozilla.org/mozilla-central/rev/1bc36f4d8ea3
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 9

7 years ago
For the reference: http://blog.mozilla.com/mrbkap/2010/02/11/xpcnativewrappersno-going-away/

I mentioned this bug at https://developer.mozilla.org/en/Chrome_Registration#xpcnativewrappers for now. Ideally we'd have a migration guide.
Target Milestone: --- → mozilla1.9.3a5

Updated

7 years ago
Depends on: 573382
Added a note to the XPCOM changes in Firefox 4 page:

https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_2.0#XPCNativeWrapper_changes

Can anyone explain to me exactly how someone would go about updating their code? I have no clue where to even start here.
I transcribed info from mrbkap's blog post to the XPCOM changes in Gecko 2.0 page, but we could still use a good step-by-step migration guide.
Duplicate of this bug: 568394
Updated more stuff, calling this done.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.