573441 - The attachments.ispatch column is a boolean without a DEFAULT

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Max Kanat-Alexander]

attachments.ispatch can be NULL, when it really should just default to FALSE.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

A very simple patch. :-)

Comment 2

[Tiago Mello [:timello]]

Comment on attachment 452679 [details] [diff] [review]
v1

>=== modified file 'Bugzilla/Install/DB.pm'
>@@ -616,6 +616,9 @@
>     $dbh->bz_alter_column('group_control_map', 'othercontrol',
>                           {TYPE => 'INT1', NOTNULL => 1, DEFAULT => CONTROLMAPNA});
> 
>+    $dbh->bz_alter_column('attachments', 'ispatch', 
>+        { TYPE => 'BOOLEAN', NOTNULL => 1, DEFAULT => 'FALSE'});
>+

Nit: I noticed that you have been adding one space after the '{' and before '}' and here you are missing the last one.

Comment 3

[Max Kanat-Alexander]

Ah, thanks, I'll fix that on checkin!

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/DB/Schema.pm
modified Bugzilla/Install/DB.pm
Committed revision 7228.