Port |Bug 554810 - CSS resize property need a transparent resize grip| to SeaMonkey

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

({modern})

Trunk
modern

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

9 years ago
Modern will need resizer PNGs and updated CSS for this.
(Assignee)

Updated

9 years ago
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
(Assignee)

Comment 1

8 years ago
Created attachment 466354 [details] [diff] [review]
Patch v1.0.

> Modern will need resizer PNGs and updated CSS for this.

Initial version. With my luck, I've probably regressed something from Bug 553937.
Attachment #466354 - Flags: review?(neil)
(Assignee)

Updated

8 years ago
Blocks: 586947
Comment on attachment 466354 [details] [diff] [review]
Patch v1.0.

>+resizer[dir="bottomright"],
>+resizer[dir="bottomend"]:-moz-locale-dir(ltr) {
...
>-resizer[dir="bottomright"],
>-resizer[dir="bottomend"]:-moz-locale-dir(ltr) {
Why bother moving the style rules?
Comment on attachment 466354 [details] [diff] [review]
Patch v1.0.

>zc%17D@N?(olHy`uVBq!ia0vp^{2<K11|+SoP4xm&Ea{HEjtmUzPnffIy#(?(3p^r=
>z85sBugD~Uq{1qucLCF%=h?3y^w370~qEv=}#LT=BJwMkFg)(D3Q$179u0IceiflYx
>z978PplM^InJ+K#;@b*(%8{34sPdp4+>*OVv6a3Upv!3u%yU9?(`^A`H`uxr!Mmu|9
>glZFZNGt(Ftj@EDg<u7k?8)y!Lr>mdKI;Vst08~dfr2qf`
[The ltr resizer has a white background for the transparent areas. It looks odd for the rtl resizer to have a black background by comparison. It also saves 3 bytes, but that's nothing compared to recompressing jesusX's old resizer.]

>+resizer[rtl="true"],
I don't think we want this rule. At least, not yet.
(Assignee)

Comment 4

8 years ago
Created attachment 466984 [details] [diff] [review]
Patch v1.1

> Comment on attachment 466354 [details] [diff] [review]
> Patch v1.0.
> 
>>+resizer[dir="bottomright"],
>>+resizer[dir="bottomend"]:-moz-locale-dir(ltr) {
> ...
>>-resizer[dir="bottomright"],
>>-resizer[dir="bottomend"]:-moz-locale-dir(ltr) {
> Why bother moving the style rules?

Moved back.

>>+resizer[rtl="true"],
> I don't think we want this rule. At least, not yet.

Removed.

>>zc%17D@N?(olHy`uVBq!ia0vp^{2<K11|+SoP4xm&Ea{HEjtmUzPnffIy#(?(3p^r=
>>z85sBugD~Uq{1qucLCF%=h?3y^w370~qEv=}#LT=BJwMkFg)(D3Q$179u0IceiflYx
>>z978PplM^InJ+K#;@b*(%8{34sPdp4+>*OVv6a3Upv!3u%yU9?(`^A`H`uxr!Mmu|9
>>glZFZNGt(Ftj@EDg<u7k?8)y!Lr>mdKI;Vst08~dfr2qf`
> [The ltr resizer has a white background for the transparent areas. It looks odd
> for the rtl resizer to have a black background by comparison. It also saves 3
> bytes, but that's nothing compared to recompressing jesusX's old resizer.]

No idea. I used to use Paintshop but my version doesn't seem to work in Win x64. So I downloaded Paint.NET and used it to flip the ltr resizer. I also downloaded GIMP but the UI made my hair stand-up. I've managed to use GIMP to flip the resizer for this patch but I still don't know how to see the background colour when it's transparent.
Attachment #466354 - Attachment is obsolete: true
Attachment #466984 - Flags: review?(neil)
Attachment #466354 - Flags: review?(neil)
(Assignee)

Comment 5

8 years ago
Created attachment 466985 [details]
resizer-rtl.png

>> [The ltr resizer has a white background for the transparent areas. It looks odd
>> for the rtl resizer to have a black background by comparison. It also saves 3
>> bytes, but that's nothing compared to recompressing jesusX's old resizer.]

Sigh. We really need a resident graphics designer.
Attachment #466985 - Flags: ui-review?(neil)
Comment on attachment 466984 [details] [diff] [review]
Patch v1.1

>diff --git a/suite/themes/modern/global/icons/resizer-rtl.png b/suite/themes/modern/global/icons/resizer-rtl.png
[Assuming attachment 466985 [details] covers this.]

>-}
>+  width: 15px;
>+  height: 15px;
>+}
>\ No newline at end of file
r=me with this fixed.
Attachment #466984 - Flags: review?(neil) → review+
Comment on attachment 466985 [details]
resizer-rtl.png

[Just for fun, I ran these images though optipng:
 2. Attached resizer-rtl.png, was 184 bytes, now 123 bytes
 2. Stock Modern resizer.png, was 217 bytes, now 148 bytes
 3. PSP resaved resizer.png, was 188 bytes, now 130 bytes!
I wonder why the rtl version gives a smaller file...]
Attachment #466985 - Flags: ui-review?(neil) → ui-review+
(Assignee)

Comment 8

8 years ago
Created attachment 467452 [details] [diff] [review]
Patch r1.2 Fix Nits. r=Neil

Carrying forward r=Neil

>>-}
>>+  width: 15px;
>>+  height: 15px;
>>+}
>>\ No newline at end of file
> r=me with this fixed.
Fixed.
Attachment #466984 - Attachment is obsolete: true
Attachment #467452 - Flags: superreview?(neil)
Attachment #467452 - Flags: review+
Attachment #467452 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 9

8 years ago
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/2ea7d2c322de
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.