573732 - Clicking a link with multiple rendered rects doesn't work

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch correct that. I still need to run the tests since my build seems broken for that...

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 453055 [details] [diff] [review]
Patch

>diff -r a6ce669575d5 chrome/content/content.js

>-  _sendMouseEvent: function _sendMouseEvent(name, element, x, y) {
>-    let windowUtils = Util.getWindowUtils(content);
>-    let scrollOffset = Util.getScrollOffset(content);
>+  _sendMouseEvent: function _sendMouseEvent(aName, aElement, aX, aY) {
>+    aX -= content.scrollX;
>+    aY -= content.scrollY;

Using content.scrollX and .scrollY will cause a reflow. We started using getScrollOffset to avoid the reflow.

This patch fixes the bug for me.

r+ with scroll offset fix

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I changed back to use getScrollOffset so we could land this patch as soon as possible. We can re-examine the use of getScrollOffset in bug 573726?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/6f38d39b3f45

Comment 4

[Dão Gottwald [:dao]]

bugspam