575295 - Clicking links broken after scrolling via in-page (uri fragment) link

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: test case

1. Open the attached test case in Fennec.
2. Click on "in-page link".  Fennec will scroll to the bottom of the page.
3. Click on "off-page link" at the bottom of the page.

Expected results: Fennec opens link to http://example.com
Actual results: Nothing happens.

This affects some real-world cases, like the "skip to menu" link on the mobile version of http://ask.metafilter.com/

Comment 1

[Matt Brubeck (:mbrubeck)]

Regression from bug 573732.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Regression from bug 573732.

yeah sounds like i've again forgot to add the scrollX/scrollY positions to the returned rects.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Adjust for scroll offset *after* client rect comparison.  (Partial revert of http://hg.mozilla.org/mobile-browser/rev/6f38d39b3f45 .)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 454867 [details] [diff] [review]
patch

     let scrollOffset = Util.getScrollOffset(content);
-    aX -= scrollOffset.x;
-    aY -= scrollOffset.y;

Nice catch. I guess let scrollOffset can also be moved next to where he is used.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/8f3efa051b27

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010630 Namoroka/4.0b2pre Fennec/2.0a1pre


follow-up bug though: bug 575999

Comment 7

[Ioana Chiorean]

https://litmus.mozilla.org/show_test.cgi?id=15190