573908 - Tab thumbnail must support remote tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Currently, tabs.xml uses a mixture of BrowserView and raw drawWindow to create the thumbnails. We use BrowserView as a speedup to render using drawImage during pageload. For remote tabs, we show a black thumbnail.

In e10s, BrowserView doesn't work quite the same way, so the speedup doesn't exist. The good news is e10s allows pageload to not be affected by rendering the thumbnail.

The patch moves the rendererFactory to browser.js so TileManager and tabs.xml can use it. We also stop using the BrowserView "shortcut" and fallback to using a default 800, 500 size - since we don't really know the size of the content when the thumbnail is rendered.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 453291 [details] [diff] [review]
patch

We could also probably remove some old workarounds for tab thumbnails as for example bug 556046.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> (From update of attachment 453291 [details] [diff] [review])
> We could also probably remove some old workarounds for tab thumbnails as for
> example bug 556046.

That code is already gone :)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/ac0d623c0b7d

Comment 4

[Dão Gottwald [:dao]]

bugspam

Comment 5

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110920
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2