HUDService.jsm sets bogus class names on toolbarbuttons

RESOLVED FIXED in Firefox 4.0b1

Status

RESOLVED FIXED
8 years ago
2 months ago

People

(Reporter: dao, Assigned: Gavin)

Tracking

Trunk
Firefox 4.0b1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
Here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/hudservice/HUDService.jsm#1982

btn.setAttribute("class", "toolbarbutton-text toolbarbutton-1 bookmark-item hud-filter-btn");

toolbarbutton-text and bookmark-item are definitely wrong. toolbarbutton-1 seems inappropriate as well, as I think it's intended for toolbarbuttons in the primary toolbars.
Patch in bug 574137 fixes this.
Depends on: 574137

Comment 2

8 years ago
you guys are awesome, thx!

Updated

8 years ago
Blocks: 529086
Fixed by https://hg.mozilla.org/mozilla-central/rev/a119d5f462f2 .
Assignee: nobody → gavin.sharp
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a6

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.