Closed Bug 574023 Opened 15 years ago Closed 15 years ago

HUDService.jsm sets bogus class names on toolbarbuttons

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b1

People

(Reporter: dao, Assigned: Gavin)

References

Details

Here: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/hudservice/HUDService.jsm#1982 btn.setAttribute("class", "toolbarbutton-text toolbarbutton-1 bookmark-item hud-filter-btn"); toolbarbutton-text and bookmark-item are definitely wrong. toolbarbutton-1 seems inappropriate as well, as I think it's intended for toolbarbuttons in the primary toolbars.
Patch in bug 574137 fixes this.
Depends on: 574137
you guys are awesome, thx!
Blocks: 529086
Fixed by https://hg.mozilla.org/mozilla-central/rev/a119d5f462f2 .
Assignee: nobody → gavin.sharp
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a6
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.