574137 - HUD Console styling should be packaged in the theme

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Right now it's all in headsUpDisplay.css.

The functional parts that are there (stuff like -moz-user-select, maybe .hud-hidden) should probably just be moved to browser.css. The rest of the appearance-related parts should be moved into theme-specific files (browser/themes/*).

Comment 1

[Philip Chee]

Why not take this opportunity to move the non-firefox specific bits to toolkit?

Comment 2

[David Dahl :ddahl]

(In reply to comment #1)
> Why not take this opportunity to move the non-firefox specific bits to toolkit?

the css bits? they are in toolkit now, and are not themeable. what do you mean?

Comment 3

[Philip Chee]

Sorry I misread references to *browser* in comment 0

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This also fixes bug 574023 (we end up losing the default-state toolbarbutton-1 styling on Windows, but I think that's OK) and bug 574235.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 453928 [details] [diff] [review]
patch

>--- a/toolkit/components/console/content/headsUpDisplay.css
>+++ b/toolkit/themes/pinstripe/global/headsUpDisplay.css

>+.hud-filter-btn .toolbarbutton-text {
>     margin: 1px 2px !important;
> }

.hud-filter-btn > .toolbarbutton-text

>--- a/toolkit/components/console/content/headsUpDisplay.css
>+++ b/toolkit/themes/winstripe/global/headsUpDisplay.css

>+.hud-filter-btn .toolbarbutton-text {
>     margin: 1px 2px !important;
> }

I don't think this should be needed for winstripe...

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/a119d5f462f2