Closed Bug 574137 Opened 10 years ago Closed 10 years ago

HUD Console styling should be packaged in the theme

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0b1

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

Right now it's all in headsUpDisplay.css.

The functional parts that are there (stuff like -moz-user-select, maybe .hud-hidden) should probably just be moved to browser.css. The rest of the appearance-related parts should be moved into theme-specific files (browser/themes/*).
Summary: HUD Console styling should be packaged in the them → HUD Console styling should be packaged in the theme
Blocks: 529086
Why not take this opportunity to move the non-firefox specific bits to toolkit?
(In reply to comment #1)
> Why not take this opportunity to move the non-firefox specific bits to toolkit?

the css bits? they are in toolkit now, and are not themeable. what do you mean?
Sorry I misread references to *browser* in comment 0
Attached patch patchSplinter Review
This also fixes bug 574023 (we end up losing the default-state toolbarbutton-1 styling on Windows, but I think that's OK) and bug 574235.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #453928 - Flags: review?(dao)
Comment on attachment 453928 [details] [diff] [review]
patch

>--- a/toolkit/components/console/content/headsUpDisplay.css
>+++ b/toolkit/themes/pinstripe/global/headsUpDisplay.css

>+.hud-filter-btn .toolbarbutton-text {
>     margin: 1px 2px !important;
> }

.hud-filter-btn > .toolbarbutton-text

>--- a/toolkit/components/console/content/headsUpDisplay.css
>+++ b/toolkit/themes/winstripe/global/headsUpDisplay.css

>+.hud-filter-btn .toolbarbutton-text {
>     margin: 1px 2px !important;
> }

I don't think this should be needed for winstripe...
Attachment #453928 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/a119d5f462f2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a6
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.