574090 - Refine OS X Toolbar Icons

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Stephen Horlander [:shorlander]]

Attachment: Refined OS X Toolbar Glyphs

Update and refine the toolbar icons as well as bring them inline with Windows where applicable.

Just an image swap.

Comment 1

[Stephen Horlander [:shorlander]]

Attachment: Screenshot of new icons

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 453456 [details] [diff] [review]
Refined OS X Toolbar Glyphs

The tabs-menu icon shouldn't be brighter than the others.

You moved the back/forward icons 1px to the top. Is this intentional?

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: Refined OS X Toolbar Glyphs

(In reply to comment #2)
> (From update of attachment 453456 [details] [diff] [review])
> The tabs-menu icon shouldn't be brighter than the others.

You are right. I didn't take into account that it could be moved now.

> You moved the back/forward icons 1px to the top. Is this intentional?

Yes it is intentional.

Thank you!

Comment 4

[Markus Stange [:mstange]]

I think I kind of intentionally moved them down 1px after comparing them to the native back/forward buttons, but I don't care at all.

Comment 5

[Stephen Horlander [:shorlander]]

(In reply to comment #4)
> I think I kind of intentionally moved them down 1px after comparing them to the
> native back/forward buttons, but I don't care at all.

Yeah I think the native ones look broken :) A lot of the Finder's icons seem to push down 1px (but not all!) for some reason.

Markus would you please check this in if you have time? If not I can poke someone else. Thanks!

Comment 6

[Markus Stange [:mstange]]

Done.

http://hg.mozilla.org/mozilla-central/rev/9666ea595351

Comment 7

[Stephen Horlander [:shorlander]]

(In reply to comment #6)
> Done.
> 
> http://hg.mozilla.org/mozilla-central/rev/9666ea595351

Thank you!