574183 - nsinstall should be ntfs aware

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Shawn Wilsher :sdwilsh]

I'd love to stop having to build int he test dir anytime I make a change to tests.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: POC in nsinstall.py

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch?

This uses hard links instead of symlinks.  I haven't tested this too much (the hardlinks work and changes are reflected though).

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 456983 [details] [diff] [review]
Patch?

Mitch, would you be able to review this.  If not, please bounce it to ted.

You should get a shortname btw.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

I was called to review this patch, but I assume it was a mistake and you're looking for a different Mitch. I'm not at all qualified to review this patch. :/

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to comment #4)
> I was called to review this patch, but I assume it was a mistake and you're
> looking for a different Mitch. I'm not at all qualified to review this patch.
> :/

You would be correct. :-)

Comment 6

[[e-mail]]

Comment on attachment 456983 [details] [diff] [review]
Patch?

>+    if (dstFileAttributes != 0xFFFFFFFF) {
>+        DeleteFile(dstFileName);
>+    }
>+
>+    if (srcFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
>+        fprintf(stderr, "nsinstall: %ls is a directory\n",
>+                srcFileName);
>+        return FALSE;
>+    } else {
>+        DWORD r;
>+        wchar_t longSrc[1004] = LONGPATH_PREFIX;
>+        wchar_t longDst[1004] = LONGPATH_PREFIX;
>+        r = GetFullPathName(srcFileName, 1000, longSrc + STR_LEN(LONGPATH_PREFIX), NULL);
>+        if (!r) {
>+            fprintf(stderr, "nsinstall: couldn't get full path of %ls: %s\n",
>+                    srcFileName, sh_GetLastErrorMessage());
>+            return FALSE;
>+        }
>+        r = GetFullPathName(dstFileName, 1000, longDst + ARRAY_LEN(LONGPATH_PREFIX) - 1, NULL);
>+        if (!r) {
>+            fprintf(stderr, "nsinstall: couldn't get full path of %ls: %s\n",
>+                    dstFileName, sh_GetLastErrorMessage());
>+            return FALSE;
>+        }
You might want to avoid deleting the source file until you've passed your other checks...

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah that's a good point.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Better Patch

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 457071 [details] [diff] [review]
Better Patch

a=beltzner

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Nasty hack to bypass the NSS bug

Lets just hack around the NSS .chk issue by suppressing errors for .chk files.  This is a substantial enough win that I think it's worth it.

Comment 11

[Mitchell Field [:Mitch]]

Comment on attachment 465124 [details] [diff] [review]
Nasty hack to bypass the NSS bug

Okay then. r=Mitch

Comment 12

[Benjamin Smedberg]

Comment on attachment 465124 [details] [diff] [review]
Nasty hack to bypass the NSS bug

At this point we are locking down the tree more, and don't want to take this until after branching.

Comment 13

[[e-mail]]

Comment on attachment 457071 [details] [diff] [review]
Better Patch

>+    BOOL willDeleteFile = (dstFileAttributes != 0xFFFFFFFF) ? TRUE : FALSE;
...
>+        if (willDeleteFile) {
[dstFileAttributs doesn't change so the temporary looks superfluous]

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 457071 [details] [diff] [review]
Better Patch

Removing approval as this has gone unlanded for so long, not sure it's worth the risk anymore.

Comment 15

[Mitchell Field [:Mitch]]

http://hg.mozilla.org/projects/build-system/rev/0c5da403b68e
http://hg.mozilla.org/projects/build-system/rev/2ef6f317bbba

Comment 16

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

MSYS has some sort of bug with hard links that manifests itself as Bug 642931.

Backed out in http://hg.mozilla.org/projects/build-system/rev/f171aeef4da1