Status

defect
RESOLVED WONTFIX
9 years ago
a year ago

People

(Reporter: sdwilsh, Assigned: khuey)

Tracking

(Depends on 1 bug)

Trunk
x86
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Reporter

Description

9 years ago
I'd love to stop having to build int he test dir anytime I make a change to tests.
Attachment #454419 - Attachment description: POC → POC in nsinstall.py
Posted patch Patch? (obsolete) — Splinter Review
This uses hard links instead of symlinks.  I haven't tested this too much (the hardlinks work and changes are reflected though).
Attachment #456983 - Flags: review?(mitcho)
Comment on attachment 456983 [details] [diff] [review]
Patch?

Mitch, would you be able to review this.  If not, please bounce it to ted.

You should get a shortname btw.
Attachment #456983 - Flags: review?(mitcho) → review?(mitchell.field)
I was called to review this patch, but I assume it was a mistake and you're looking for a different Mitch. I'm not at all qualified to review this patch. :/
(In reply to comment #4)
> I was called to review this patch, but I assume it was a mistake and you're
> looking for a different Mitch. I'm not at all qualified to review this patch.
> :/

You would be correct. :-)
Comment on attachment 456983 [details] [diff] [review]
Patch?

>+    if (dstFileAttributes != 0xFFFFFFFF) {
>+        DeleteFile(dstFileName);
>+    }
>+
>+    if (srcFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
>+        fprintf(stderr, "nsinstall: %ls is a directory\n",
>+                srcFileName);
>+        return FALSE;
>+    } else {
>+        DWORD r;
>+        wchar_t longSrc[1004] = LONGPATH_PREFIX;
>+        wchar_t longDst[1004] = LONGPATH_PREFIX;
>+        r = GetFullPathName(srcFileName, 1000, longSrc + STR_LEN(LONGPATH_PREFIX), NULL);
>+        if (!r) {
>+            fprintf(stderr, "nsinstall: couldn't get full path of %ls: %s\n",
>+                    srcFileName, sh_GetLastErrorMessage());
>+            return FALSE;
>+        }
>+        r = GetFullPathName(dstFileName, 1000, longDst + ARRAY_LEN(LONGPATH_PREFIX) - 1, NULL);
>+        if (!r) {
>+            fprintf(stderr, "nsinstall: couldn't get full path of %ls: %s\n",
>+                    dstFileName, sh_GetLastErrorMessage());
>+            return FALSE;
>+        }
You might want to avoid deleting the source file until you've passed your other checks...
Posted patch Better PatchSplinter Review
Attachment #454419 - Attachment is obsolete: true
Attachment #456983 - Attachment is obsolete: true
Attachment #457071 - Flags: review?(mitchell.field)
Attachment #456983 - Flags: review?(mitchell.field)
Attachment #457071 - Flags: review?(mitchell.field) → review+
Comment on attachment 457071 [details] [diff] [review]
Better Patch

a=beltzner
Attachment #457071 - Flags: approval2.0? → approval2.0+
Lets just hack around the NSS .chk issue by suppressing errors for .chk files.  This is a substantial enough win that I think it's worth it.
Attachment #465124 - Flags: review?(mitchell.field)
Comment on attachment 465124 [details] [diff] [review]
Nasty hack to bypass the NSS bug

Okay then. r=Mitch
Attachment #465124 - Flags: review?(mitchell.field)
Attachment #465124 - Flags: review+
Attachment #465124 - Flags: approval2.0?
Comment on attachment 465124 [details] [diff] [review]
Nasty hack to bypass the NSS bug

At this point we are locking down the tree more, and don't want to take this until after branching.
Attachment #465124 - Flags: approval2.0? → approval2.0-
Comment on attachment 457071 [details] [diff] [review]
Better Patch

>+    BOOL willDeleteFile = (dstFileAttributes != 0xFFFFFFFF) ? TRUE : FALSE;
...
>+        if (willDeleteFile) {
[dstFileAttributs doesn't change so the temporary looks superfluous]
Comment on attachment 457071 [details] [diff] [review]
Better Patch

Removing approval as this has gone unlanded for so long, not sure it's worth the risk anymore.
Attachment #457071 - Flags: approval2.0+ → approval2.0-
MSYS has some sort of bug with hard links that manifests itself as Bug 642931.

Backed out in http://hg.mozilla.org/projects/build-system/rev/f171aeef4da1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX
Whiteboard: fixed-in-bs

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.