574188 - Figure out where in the Firefox codebase TabCandy needs to land

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Ian Gilman [:iangilman]]

TabCandy won't be a separate XPI, so where does it need to go in the Firefox code?

Comment 1

[Ed Lee :Mardak]

I would assume it'll live under..

browser/components/tabcandy

There'll be some stuff directly in browser/base/content to hook into tabcandy.

The jar.mn file can map things into chrome://browser/content/tabcandy/.. for loading the page in the xul:deck, etc.

Comment 2

[Ian Gilman [:iangilman]]

Based on conversation with mardak today, looks like it actually needs to go in:

browser/base/content/tabcandy

Inside that folder, we'll have a tabcandy.js that is just a bunch of #include for all of the other js files. We'll also have our image files (though some, like our navbar icon, may need to live elsewhere) and our index.html. Perhaps we should fold our CSS into index.html to save a file?

We'll need to add our contents to: 

browser/base/jar.mn

Note that instead of chrome://tabcandy/content, our new path will be: 

chrome://browser/content/tabcandy/

Comment 3

[Ed Lee :Mardak]

So the xul:deck browser will probably load chrome://browser/content/tabcandy/index.html and that page loads the unified chrome://browser/content/tabcandy/tabcandy.js

Comment 4

[Ian Gilman [:iangilman]]

In addition, we'll need to: 

* Add the toolbar button directly to the xul rather than adding it dynamically as we do now. 

* Update all of our chrome://tabcandy references to chrome://browser/.../tabcandy. For instance, images and css will be at chrome://browser/skin/tabcandy/. 

* Duplicate image for windows and linux themes

Comment 5

[Ed Lee :Mardak]

Attachment: hg convert filemap v1

Here's a filemap that will move the js, css, images, xhtml files to the right places.

Comment 6

[Ed Lee :Mardak]

test.js probably is unneeded so need to exclude that from the filemap

Comment 7

[Ian Gilman [:iangilman]]

The tests from test.js need to be integrated into the Firefox unit test framework. Where is that? How is that done?

Comment 8

[Ian Gilman [:iangilman]]

The file map looks great, by the way. I'm still confused about merging firefoxOverlay.xul into browser.xul will work; the "rename" makes me think we'll just clobber browser.xul. Just my lack of Mercurial skills, I suppose.

Comment 9

[Ed Lee :Mardak]

I'll be converting one repo into another. You can think of it as you having two repositories A and B that happen to have the same file foo. If you were in repo A and did a "hg pull B", it'll pull the changesets into repo A but it'll exist as a branch. Only after a "hg merge" will there be a final merged repo "AB", and during the merge, you'll need to resolve the merge conflicts of A/foo and B/foo.

Comment 10

[Ed Lee :Mardak]

I would assume we'll need mochitests for the tests as it involves UI/rendering pieces and not just JS code functionality.

Comment 11

[Ian Gilman [:iangilman]]

(In reply to comment #10)
> I would assume we'll need mochitests for the tests as it involves UI/rendering
> pieces and not just JS code functionality.

Where do we put the mochitests?

Comment 12

[Ed Lee :Mardak]

Attachment: hg convert filemap v2

Added more renames to preserve more history in the same file and removed the firefox overlay and tests for now.

Comment 13

[Ed Lee :Mardak]

Attachment: jar.mn v1

Builds tabcandy.js and update jar.mn for content files

Comment 14

[Ed Lee :Mardak]

Attachment: UI v1

Hook up view menu, toolbar, keyboard shortcut with new icon from shorlander.

Comment 15

[Ed Lee :Mardak]

Attachment: jar.mn v2

Fix up chrome://tabcandy references and hook up tabcandy.js, jar.mn for content and skin.

Comment 16

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/700bdb469779
Add UI hooks to trigger tab candy 

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/da9dfdef8dfe
Include individual js pieces into tabcandy.js and expose content and skin files with jar.mn 

After building a non-debug build of Firefox, tabcandy should be usable.

There's still some missing bits like windows and linux theme files and integrating tests.

Comment 17

[Ed Lee :Mardak]

Attachment: glyph mac (from shorlander)

Comment 18

[Ed Lee :Mardak]

Attachment: glyph win (from shorlander)

Comment 19

[Ian Gilman [:iangilman]]

I've now taken care of the windows and linux versions of the theme files (hopefully I did it right): 

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/2763944239c2

I've also created a bug for unit tests (Bug 577321). 

With that, I think this bug is resolved.

Comment 20

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".