Last Comment Bug 574290 - [EB] Implement "Add to Collection" interaction on the add-on details page
: [EB] Implement "Add to Collection" interaction on the add-on details page
Product: Graveyard
Classification: Graveyard
Component: Collections (show other bugs)
: unspecified
: All All
P1 normal
: 5.11.8
Assigned To: Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)
Depends on: 579086
Blocks: 574291
  Show dependency treegraph
Reported: 2010-06-23 23:21 PDT by Wil Clouser [:clouserw]
Modified: 2016-02-04 14:48 PST (History)
3 users (show)
stephen.donner: in‑testsuite?
stephen.donner: in‑litmus?
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Description User image Wil Clouser [:clouserw] 2010-06-23 23:21:13 PDT
One of the new links on the Add-on details page is "Add to Collection."  See location and layout on these mockups:

And see the interaction flow here:

This bug is for the full implementation of this widget on detail pages and on listing pages.  Remember scalability was an issue when dealing with this widget in remora.  Don't forget unit tests for things like "This add-on is already in the collection, show it as checked."  See the spec for details, section "Add-on Details page":
Comment 1 User image Dave Dash [:davedash, :dd] (assign all bugs to mbrandt) 2010-07-06 12:19:14 PDT
In what way was this a scaling issue for remora?

For most people it'll show the login prompt, for the logged in people we should be able to power this all via AJAX.
Comment 2 User image Wil Clouser [:clouserw] 2010-07-06 15:10:14 PDT
The scaling problem came from us showing all the user's collections, and then taking out any collections that the add-on was already a part of.  It looks like we're doing the same thing here, so we just need to make sure that query is as fast as it can be.

Loading this via ajax wfm.
Comment 3 User image Dave Dash [:davedash, :dd] (assign all bugs to mbrandt) 2010-07-14 15:10:02 PDT
Code is being reviewed by potch, and then will be styled by him too:

I might use event delegation to avoid re-attaching handlers, but I haven't decided yet.
Comment 4 User image Wil Clouser [:clouserw] 2010-07-19 13:38:50 PDT
This is pretty much done, but needs styling.
Comment 5 User image Dave Dash [:davedash, :dd] (assign all bugs to mbrandt) 2010-08-03 14:54:58 PDT
Comment 6 User image Stephen Donner [:stephend] 2010-08-06 01:58:54 PDT
We disabled this on both preview/next, where it wasn't doing anything (404s).
Comment 7 User image Dave Dash [:davedash, :dd] (assign all bugs to mbrandt) 2010-08-06 06:40:30 PDT
was zamboni serving these urls?
Comment 8 User image Jeff Balogh (:jbalogh) 2010-08-06 08:17:47 PDT
(In reply to comment #7)
> was zamboni serving these urls?

No.  We blocked this code with the NEW_COLLECTIONS flag since we can't run the EB collection migrations on prod and I don't know how the backend will work without it.

QA: There's nothing broken about this bug.  We just need to flip NEW_COLLECTIONS to get it back.
Comment 9 User image Stephen Donner [:stephend] 2010-09-07 18:47:01 PDT
Verified FIXED (implemented).

Note You need to log in before you can comment on or make changes to this bug.