574293 - [EB] Implement new "Install Multiple Add-ons" buttons & page

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Collections, defect, P2)

Description

[Wil Clouser [:clouserw]]

Electric bandwagon finally lets us install multiple add-ons.  Unfortunately, that means changing our buttons.  If people choose to install multiple add-ons from a collection at once, they're sent to a special listing page:

http://people.mozilla.com/~chowse/drop/amo/electric-bandwagon/v1/Collection_Listing_MultipleInstall.png

Checking the box here adds the add-on to the list on the right, and choosing 'add selected' from there will trigger the install.

This bug includes:
- Complete development of this page.
- Complete development of the button modifications.  I'm including this with the page because they'll interact together
- Only show the popup on "select all" if the page is paginated
- The spec calls for AJAX loading of the list so we don't lose the list in the right column.  I'm flexible on that as long as the list in the right column persists.
- We won't show users contribution roadblocks, but we do need to show them EULAs.
- Please keep the smorgasbord up to date with new buttons

See "Installing Multiple Add-ons" in the spec for more details: https://docs.google.com/Doc?docid=0Acwo2Bn17-PrZGZudHRobnJfNjVjYnFqMm5kZw&hl=en

Comment 1

[Jeff Balogh (:jbalogh)]

(In reply to comment #0)
> Electric bandwagon finally lets us install multiple add-ons.  Unfortunately,
> that means changing our buttons.

Say it ain't so!

> - We won't show users contribution roadblocks, but we do need to show them
> EULAs.

The spec is blissfully naive in its consideration of button issues.  What are we going to do about platform popups, version popups, unreviewed add-ons, and other new cases that get invented before we get here?  Will search engines work with these multi-install parties?  They don't go through InstallTrigger.

Comment 2

[Jeff Balogh (:jbalogh)]

=> flighowse for the questions in comment 1 (add personas to the sad list).

Comment 3

[Justin Scott [:fligtar]]

If the user manually checks a button, it should do the same thing as if it were an install button but with "Add to Firefox" replaced with "Include this add-on"

If the user hits Select All, the overlay that comes up should have under the "10 add-ons...":
3 Personas were not selected
4 incompatible add-ons were not selected
2 search providers were not selected
3 unreviewed add-ons were not selected

For all of those cases, the user must manually check the box to include it, except for Personas, which can't be included.

Comment 4

[Wil Clouser [:clouserw]]

I don't think we can do search providers with this either.  They are a special function call in the JS

Comment 5

[Jeff Balogh (:jbalogh)]

potch: like the Mobile buttons, here's another case where we don't actually follow the links on the buttons. Now we're checking a box instead of POSTing a form.  We need some kind of delayed action framework to handle all this ridiculousness.

fligtar: EULAs?

mossop: What is the preferred way to install multiple add-ons?  Is there a way to install multiple search providers?

Comment 6

[Dave Townsend [:mossop]]

(In reply to comment #5)
> mossop: What is the preferred way to install multiple add-ons?  Is there a way
> to install multiple search providers?

I know next to nothing about search providers, Ryan or Gavin can help you there.

For XPI's you can just pass multiple XPIs to the same InstallTrigger.install call like so:

InstallTrigger.install({
  name1: {
    URL: "http://foo.com/xpi1.xpi"
  },
  name2: {
    URL: "http://foo.com/xpi1.xpi"
  }
}

Comment 7

[Wil Clouser [:clouserw]]

What's the status here?  Should we just grey the buttons out for search engines?

Comment 8

[Justin Scott [:fligtar]]

I addressed search providers in comment #3 for multi-install.

Comment 9

[Wil Clouser [:clouserw]]

(In reply to comment #8)
> I addressed search providers in comment #3 for multi-install.

Great, so, is this waiting on you for something?  Why is it assigned to you?

Comment 10

[Jeff Balogh (:jbalogh)]

(In reply to comment #9)
> Great, so, is this waiting on you for something?  Why is it assigned to you?

EULAs.

Comment 11

[Justin Scott [:fligtar]]

I assumed Wil was taking care of the EULA case since we talked about it. Wil, did you want me to explain what we talked about or are you still handling it?

Comment 12

[Wil Clouser [:clouserw]]

(In reply to comment #11)
> I assumed Wil was taking care of the EULA case since we talked about it. Wil,
> did you want me to explain what we talked about or are you still handling it?

Did we ever decide on links vs textareas?  Please explain!

Comment 13

[Jeff Balogh (:jbalogh)]

Please write your secrets in the bugs where everyone can see.

Comment 14

[Justin Scott [:fligtar]]

We should do the same thing we do in Fashion Your Firefox:

* When a user clicks the button to install the selected add-ons, if any of them have EULAs we should display a dialog that lists each add-on with a EULA and separate agreement boxes for each: http://grab.by/5XSk

* Clicking the link to view the EULA toggles the EULA in-line: http://grab.by/5XSn

I will file a bug for a chowsified version of these screenshots.

Comment 16

[Jeff Balogh (:jbalogh)]

Duped the wrong way.

Comment 18

[Wil Clouser [:clouserw]]

Potch says this is 40-50% done, but needs more work.  It's not a part of the dev tools though, so I'm bumping it.

Comment 19

[Jan [:Jan\]]

what is the status about this enhancement ?

Comment 20

[Wil Clouser [:clouserw]]

Thanks for filing this.  In an effort to not drown in existing reports we're aggressively closing old enhancements and bugs to get the buglist to a reasonable level so we can scope and process bug sprints in an effective manner.

Patches for this bug are still welcome.