Closed Bug 574403 Opened 10 years ago Closed 8 years ago

Build failure with --enable-dtrace

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: sfink, Assigned: sfink)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file, 6 obsolete files)

Attached file Build log (obsolete) —
I am trying to use SystemTap's dtrace compatibility tools to compile with --enable-dtrace on x86_64. The compile fails with numerous errors like

  undefined reference to `function__info_semaphore'

The symbol is defined in mozjs-dtrace.o, which is linked into libmozjs.so, which is included in the compile command line. The problem is that although the above symbol (and several others) are exported in mozjs-dtrace.o, they are converted to local symbols in libmozjs.so:

  % nm mozjs-dtrace.o| fgrep function__info_
  0000000000000002 D function__info_semaphore
  % nm libmozjs.so | fgrep function__info_   
  00000000004b871e d function__info_semaphore

I have posted a question about this to http://stackoverflow.com/questions/3106302/force-linker-to-export-a-resolved-symbol-when-creating-shared-library where someone suggested it was a linker bug and to try the latest version of ld. I did, but it didn't help. (I don't understand the linker well enough to know how this is supposed to work.)
Attachment #453797 - Attachment mime type: application/octet-stream → text/plain
Assignee: nobody → general
Component: JavaScript Debugging APIs → JavaScript Engine
QA Contact: jsd → general
Attached patch Hack to make it work (obsolete) — Splinter Review
Something very odd is going on during linking. If I relink and specify mozjs-dtrace.o again, then everything works. (Except you need to do the equivalent for libjs_static.a as well, but I think it's just missing the file in the first place.)

The attached patch is a horrible hack that forces it to do the extra linking. It's still unclear to me whether this is a linker bug or what.
I lied. The attached patch makes the js directory build, because it uses libjs_static.a. But there seems to be no easy way to update a .so with a new object file; the hack in the patch just creates a new .so containing only the .o I wanted added.

So currently the only workaround is to add mozjs-dtrace.o to every link line that needs it.
Attached patch Part 1: alternative hack (obsolete) — Splinter Review
This plus the next patch will make it work in the ugliest way possible.
Attachment #455765 - Attachment is obsolete: true
Attached patch Part 2: alternative hack (obsolete) — Splinter Review
Nasty workaround to link in the object to the static lib. I'm sure there are better ways.

NOT FOR COMMIT
There is also a compile failure due to underparenthesized macros in <system/sdt.h>. These problems all only apply on non-OSX systems, since on OSX dtrace doesn't require the "dtrace -G" step where you pull out the locations of all the probe points into a separate object file.
Summary: Build (link) failure with --enable-dtrace → Build failure with --enable-dtrace
I should also mention that in some version of the build scripts, firefox-bin fails to include the dtrace probe symbols because it links with both libxul.so and libmozjs.so. The symbols are present and exported in libmozjs.so, but it doesn't link them in because the symbols that cause the necessary object files to be linked in are also present in libxul.so, so only it gets linked in and (those portions of) libmozjs.so are unused. But in libxul.so, the symbols are present but not exported.

I'm actively working on getting a build system that works with both OSX dtrace and systemtap dtrace.
Things seemed to have changed. The attached patch is all that I needed to get things compiling with both systemtap on Linux and dtrace on OSX.

With systemtap, you can check whether the probes have been compiled in with:
  stap -L 'process("./js").mark("*")'
I notice that the 'const char *' parameters are not set to stap's 'string' type, but are instead all 'long'. They can be successfully used with eg 'user_string($arg1)' though. (I am using systemtap 1.4 on Fedora 14.)

I haven't figured out how to make OSX's dtrace display the probes yet. But it compiles and links successfully. I'll r? when I can figure out how to use it there.
Attachment #453797 - Attachment is obsolete: true
Attachment #460598 - Attachment is obsolete: true
Attachment #460601 - Attachment is obsolete: true
Attachment #477211 - Attachment is obsolete: true
Comment on attachment 546671 [details] [diff] [review]
Fix --enable-dtrace build for both OSX and Linux

Ok, I got dtrace on OSX to admit that the probes exist. It's not very smart about it; it mixes in IS_ENABLED() tests with the actual probes, which makes it really hard to restrict to the right probe (and you need to, if you want to use the probe arguments).

Anyway, this does seem to be working on both Linux and OSX. I just pushed to try and requested results to be posted here. But my own debug builds on OSX and Linux64 both worked.

I'm absolutely kinda sorta sure that this doesn't depend on the two cleanup patches I have ahead of this in my queue.
Attachment #546671 - Flags: review?(khuey)
Try run for 90830cd2cf4a is complete.
Detailed breakdown of the results available here:
    http://tbpl.mozilla.org/?tree=Try&rev=90830cd2cf4a
Results:
    success: 11
Total buildrequests: 11
(In reply to comment #10)
> Try run for 90830cd2cf4a is complete.
> Detailed breakdown of the results available here:
>     http://tbpl.mozilla.org/?tree=Try&rev=90830cd2cf4a
> Results:
>     success: 11
> Total buildrequests: 11

...and please ignore that happy output. I neglected to hg add my mozconfig-extra, so dtrace wasn't enabled anyway. I just kicked off a run with that corrected, so 671f2368f50c should show up here eventually.
Try run for 671f2368f50c is complete.
Detailed breakdown of the results available here:
    http://tbpl.mozilla.org/?tree=Try&rev=671f2368f50c
Results:
    success: 3
    warnings: 1
    failure: 7
Total buildrequests: 11
Comment on attachment 546671 [details] [diff] [review]
Fix --enable-dtrace build for both OSX and Linux

* sfink learns about the drawbacks of having try server update bugs
Attachment #546671 - Flags: review?(khuey)
Duplicate of this bug: 619661
This passes try. (In fact, none of the previous try failures were the fault of this patch. The last problem seems to have gone away on its own recently. Hopefully this won't bounce and make me a liar.)

Note that bug 673753 added the systemtap devel package to all Linux build machines, so this should be enable-able now.
Assignee: general → sphink
Attachment #546671 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #552603 - Flags: review?(khuey)
http://hg.mozilla.org/mozilla-central/rev/fcb383e5e61e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Depends on: 678954
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.