Build failure with --enable-dtrace on Solaris

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ginn Chen, Assigned: sfink)

Tracking

Trunk
mozilla9
All
Solaris
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
It was broken since Bug 574403 was committed.

While linking js

Undefined			first referenced
 symbol  			    in file
__dtraceenabled_javascript___execute__start ../libjs_static.a(jsinvoke.o)
__dtrace_javascript___execute__start ../libjs_static.a(jsinvoke.o)
__dtrace_javascript___function__return ../libjs_static.a(jsprobes.o)
__dtraceenabled_javascript___object__finalize ../libjs_static.a(jsgc.o)
__dtraceenabled_javascript___execute__done ../libjs_static.a(jsinvoke.o)
__dtrace_javascript___object__create ../libjs_static.a(jsapi.o)
__dtraceenabled_javascript___function__entry ../libjs_static.a(jsarray.o)
__dtrace_javascript___execute__done ../libjs_static.a(jsinvoke.o)
__dtraceenabled_javascript___function__return ../libjs_static.a(jsarray.o)
__dtrace_javascript___object__finalize ../libjs_static.a(jsgc.o)
__dtraceenabled_javascript___object__create ../libjs_static.a(jsapi.o)
__dtrace_javascript___function__entry ../libjs_static.a(jsprobes.o)
ld: fatal: symbol referencing errors. No output written to js

It is incorrect to remove $(OBJS) from dtrace command line.
Please add #if LINUX, if you have to do so.
(Assignee)

Comment 1

6 years ago
Created attachment 553885 [details] [diff] [review]
Add back OBJS to dtrace command

Does this work for you? systemtap's dtrace seems fine with the object files, now that they are no longer necessary.
(Reporter)

Comment 2

6 years ago
It works, thanks!

BTW: You need to keep config/rules.mk and js/src/config/rules.mk identical.
(Assignee)

Comment 3

6 years ago
Created attachment 554500 [details] [diff] [review]
Add back OBJS to dtrace command
Attachment #553885 - Attachment is obsolete: true
Attachment #554500 - Flags: review?(khuey)
Attachment #554500 - Flags: review?(khuey) → review+
http://hg.mozilla.org/mozilla-central/rev/713be47aa3f9
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.