574599 - content not repainted when dismissing 2nd level menu since drawing on titlebar landing

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[aja+bugzilla]

A white rectangle is left when dismissing any 2nd level menu (with esc), whether opened from firefox button or menu.

Regression shows in 1st hourly after bug 513162 landed,
was okay in prior hourly http://hg.mozilla.org/mozilla-central/rev/522df66198cf

Comment 1

[aja+bugzilla]

Another description of bug:
http://forums.mozillazine.org/viewtopic.php?p=9538343#p9538343

Comment 2

[Brian Polidoro]

I see this with tooltips and context menus only from the content area.  If the content area tooltips or context menu overlaps chrome then I don't see the problem.  Chrome tooltips and menus seem fine even if they overlap the content area. 

As for dialogs I only see this if the dialog is only over the content area.  If the dialog overlaps any chrome area then the problem does not occur.  Also it does not occur if you close the dialog.  It only happens when you change focus from the dialog to browser window.

Comment 3

[Brian Polidoro]

>Also it does not occur if you close the dialog.  It only happens when you change focus from the dialog to browser window.

Scratch that now I got that to happen.  It doesn't happen with the options dialog when you use the 'Close' button.  But it does if you use the 'X' button in the top right of the dialog.

Comment 4

[Alice0775 White]

See Bug 574608,
The problem happens not only Firefox's dialog/menu but also other application window.
it happens with Windows7 Classic and WindowsXP Classic and Luna style.
however It does not happen with Windows7 Aero Style.

Comment 5

[Brian Polidoro]

"The problem happens not only Firefox's dialog/menu but also other application
window."  
If it overlaps any chrome it doesn't happen.

Comment 6

[rsx11m]

(In reply to comment #2)
> I see this with tooltips and context menus only from the content area.  If the
> content area tooltips or context menu overlaps chrome then I don't see the
> problem.  Chrome tooltips and menus seem fine even if they overlap the content
> area. 

Confirmed with today's Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a6pre) Gecko/20100625 SeaMonkey/2.1a3pre nightly build. I'm using Windows Classic desktop theme.

Also, closing a tab which results in focusing another tab will briefly show that tab's content when rendered, then it's blank (dialog background color).

Comment 11

[Jim Mathies [:jimm]]

Attachment: fix

Comment 12

[Jim Mathies [:jimm]]

The first two changes are ^M cleanup from the last patch. :/

Comment 14

[Ryan Jones-Ward [:sciguyryan]]

Are you sure that Bug 574631 is a duplicate of this one? I didn't even go near any menus when this occurred - the browser literally started that way.

Comment 15

[Jim Mathies [:jimm]]

(In reply to comment #14)
> Are you sure that Bug 574631 is a duplicate of this one? I didn't even go near
> any menus when this occurred - the browser literally started that way.

yes.

Comment 17

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/768050959b3c

Comment 18

[aja+bugzilla]

(In reply to comment #17)
> http://hg.mozilla.org/mozilla-central/rev/768050959b3c

WFM now with this patch.

Comment 19

[Bas Schouten (:bas.schouten)]

Attachment: Add WS_CLIPCHILDREN to the relevant windowstyles

The previous patch wasn't complete, when using Aero Glass the style would be set back to a style without WS_CLIPCHILDREN when SetWindowInnerTranslucency would be called. This patch will fix that.

Comment 20

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/6a485d75abdc

Comment 21

[Gary [:streetwolf52]]

Have this patch applied and when I start Fx maximized I briefly see a white rectangle near the upper left side of the screen.  It might be related to the new menu bar.

D2D disabled
DW enabled.

Comment 22

[Gary [:streetwolf52]]

Almost forgot I also briefly see a small caption bar, upper left, only containing Min, Max, Restore buttons when I start Fx.  So many glitches with the new titlebar I don't know where to file reports anymore?

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100626 Minefield/3.7a6pre Firefox/3.6.4 - Build ID: 20100626035857

Comment 23

[Alice0775 White]

(In reply to comment #22)
> Almost forgot I also briefly see a small caption bar, upper left, only
> containing Min, Max, Restore buttons when I start Fx.  So many glitches with
> the new titlebar I don't know where to file reports anymore?
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre)
> Gecko/20100626 Minefield/3.7a6pre Firefox/3.6.4 - Build ID: 20100626035857
It seems to be Bug 574690

Comment 24

[rsx11m]

(comment #6) I see some weird behavior on opening new windows as well, e.g.,
the multi-pane Mail & News window on SeaMonkey first opens in a smaller size
and shifted up and left, then the dividers rearrange to line up with the target window size. All other issues reported are solved on SeaMonkey trunk too.