575086 - 31 days query results in "Unable to Complete Request"

Status: RESOLVED DUPLICATE of bug 610457

(Socorro :: General, task)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #482441 +++

bug 482441 provided longer query (thanks!) - 120 days - and I'm finally checking the functionality.  But the results are not usable ...

1. from http://crash-stats.mozilla.com/query do query for 31 days against nsPrefBranch::Observe(nsISupports*, char const*, unsigned short const*) - i.e. http://crash-stats.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=exact&query=nsPrefBranch%3A%3AObserve%28nsISupports*%2C%20char%20const*%2C%20unsigned%20short%20const*%29&date=06%2F27%2F2010%2008%3A32%3A38&range_value=31&range_unit=days&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=1&signature=nsPrefBranch%3A%3AObserve%28nsISupports*%2C%20char%20const*%2C%20unsigned%20short%20const*%29
2. click link to bring up results list of crashes

"Unable to Complete Request"

3. shorten query to 30 days
works

in short ...

works 30days http://crash-stats.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=exact&query=nsPrefBranch%3A%3AObserve(nsISupports*%2C char const*%2C unsigned short const*)&date=06%2F27%2F2010 08%3A32%3A38&range_value=30&range_unit=days&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=1&signature=nsPrefBranch%3A%3AObserve(nsISupports*%2C char const*%2C unsigned short const*)

fails 31days http://crash-stats.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=exact&query=nsPrefBranch%3A%3AObserve(nsISupports*%2C char const*%2C unsigned short const*)&date=06%2F27%2F2010 08%3A32%3A38&range_value=31&range_unit=days&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=1&signature=nsPrefBranch%3A%3AObserve(nsISupports*%2C char const*%2C unsigned short const*)

Comment 1

[Laura Thomson :laura]

Sounds like a problem with bug 482441 - Ryan, over to you.

Comment 2

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks, I'll take a look...

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

From what I can tell, the $config['query_range_defaults'] parameters is missing from config/application.php.  Will investigate.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 1 for 575086

Turns out it wasn't an issue with the config file, but rather because the code did not have an isset() statement before checking the value of a parameter. Also added an admin parameter in the report->do_list() controller.

Comment 5

[Austin King [:ozten]]

Comment on attachment 454992 [details] [diff] [review]
Patch 1 for 575086

looks good, but let's get rid of the multiple calls to isset.

> (!isset($params['admin']) || (isset($params['admin']) && $params['admin'] === false))

The second isset is redundant since we won't get past || unless $params['admin'] is set.
The first !isset($params['admin']) will short circuit the || expression when true. 

The grouping is hard to scan visually, so this might help.

Comment 6

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks Austin!  

This will be available for testing on stage in 15 minutes.

==

Sending        webapp-php/application/controllers/report.php
Sending        webapp-php/application/libraries/MY_SearchReportHelper.php
Transmitting file data ..
Committed revision r2187.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://crash-stats.stage.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=exact&query=nsPrefBranch%3A%3AObserve%28nsISupports*%2C%20char%20const*%2C%20unsigned%20short%20const*%29&date=06%2F27%2F2010%2008%3A32%3A38&range_value=31&range_unit=days&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=1&signature=nsPrefBranch%3A%3AObserve%28nsISupports*%2C%20char%20const*%2C%20unsigned%20short%20const*%29; I now get:

Uh oh! Something went wrong...

    The maximum query date range you can perform is 30 days. Admins may log in to increase query date range limits. Query results have been narrowed to the default range of 14 days.

Comment 8

[Laura Thomson :laura]

Merge to 1.7.6

Comment 9

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

This can also be tested using the following url:

http://crash-stats.stage.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=exact&query=nsMsgSearchSession%3A%3AGetRunningAdapter%28nsIMsgSearchAdapter**%29&date=11%2F04%2F2010%2014%3A08%3A07&range_value=16&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=1&signature=nsMsgSearchSession%3A%3AGetRunningAdapter%28nsIMsgSearchAdapter**%29

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #9)
> This can also be tested using the following url:
> 
> http://crash-stats.stage.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=exact&query=nsMsgSearchSession%3A%3AGetRunningAdapter%28nsIMsgSearchAdapter**%29&date=11%2F04%2F2010%2014%3A08%3A07&range_value=16&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=1&signature=nsMsgSearchSession%3A%3AGetRunningAdapter%28nsIMsgSearchAdapter**%29

This URL doesn't work for me, so I filed bug 610702.

Comment 11

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

This works.  But only in HTTPS.  Socorro UI does not recognize admins unless we are using HTTPS.  Resolving as a duplicate of Bug 610457.