Closed
Bug 575109
Opened 16 years ago
Closed 16 years ago
Don't unnecessarily inherit from nsISupports (vtable bloat)
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
24.06 KB,
patch
|
surkov
:
review+
davidb
:
review+
|
Details | Diff | Splinter Review |
The CAccessible objects inherit from nsISupports because do_QueryInterface only accepts an nsISupports parameter. However the new do_QueryObject only requires the declaration of the QueryInterface method. Notes: CAccessibleHyperlink.h has to redeclare QueryInterface otherwise the IUnknown version shadows it; CAccessibleHypertext.h already declares QueryInterface.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #454383 -
Flags: review?(surkov.alexander)
Attachment #454383 -
Flags: review?(bolterbugz)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 454383 [details] [diff] [review]
Proposed patch
thank you for fixing this, r=me
Attachment #454383 -
Flags: review?(surkov.alexander) → review+
|
||
Comment 4•16 years ago
|
||
Can I have a try-server build for this please? I'd like to give this a quick run against MSAA/IAccessible2 AT software.
|
|
||
Comment 5•16 years ago
|
||
(In reply to comment #4)
> Can I have a try-server build for this please? I'd like to give this a quick
> run against MSAA/IAccessible2 AT software.
It's safe change I'm not sure it's necessary to bother you by testing.
|
|
||
Comment 6•16 years ago
|
||
OK, thanks!
|
||
Comment 7•16 years ago
|
||
Comment on attachment 454383 [details] [diff] [review]
Proposed patch
r=me. I think I like do_QueryObject :)
Attachment #454383 -
Flags: review?(bolterbugz) → review+
|
|
||
Comment 8•16 years ago
|
||
land on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/6a5c4b7bcabe
Assignee: nobody → neil
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•