575228 - When maximizing window, the menu bar gets pushed down.

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[imradyurrad]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100627 Minefield/3.7a6pre

With the latest hourly (28-Jun-2010 04:50)
If you maximize a window the menu bar, navigation bar, etc get pushed down about 4px.

Reproducible: Always

Comment 1

[Peter Henkel [:Terepin]]

Screenshot please.

Comment 2

[Kevin Brosnan]

Sounds like bug 574821

Comment 3

[imradyurrad]

(In reply to comment #1)
> Screenshot please.

Working on one right now. 
You have to have the title bar enabled to see it.

Comment 4

[Peter Henkel [:Terepin]]

(In reply to comment #3)
> (In reply to comment #1)
> You have to have the title bar enabled to see it.

I didn't know it can be disabled in the first place :)
But indeed it seems like bug 574821. But that is by design, this was made because Firefox Menu was cut of when window was maximized.

Comment 5

[imradyurrad]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #1)
> > You have to have the title bar enabled to see it.
> 
> I didn't know it can be disabled in the first place :)
> But indeed it seems like bug 574821. But that is by design, this was made
> because Firefox Menu was cut of when window was maximized.

Menu bar I meant.

In the description, it's more like 1 or 2px not four.

Comment 6

[imradyurrad]

Mr. Henky, this happens without the Firefox button.

Comment 7

[Tan Wei Lin Jason [:Ryuji]]

Attachment: However I don't see the problem that you mention

Comment 8

[imradyurrad]

Attachment: problem mentioned

Comment 9

[imradyurrad]

(In reply to comment #7)
> Created an attachment (id=454507) [details]
> However I don't see the problem that you mention

See attachment.

Comment 10

[Jim Mathies [:jimm]]

(In reply to comment #2)
> Sounds like bug 574821

Definitely that, the css we added there - 

+  /* the new titlebar requires this, or content will be clipped at the top of the screen. */
+  #main-window[sizemode="maximized"] {
+    margin-top: 8px;
+  }
+


Needs to be conditional on the fx button being displayed.

Comment 11

[Jim Mathies [:jimm]]

Attachment: update

Comment 12

[Jim Mathies [:jimm]]

Comment on attachment 454758 [details] [diff] [review]
update

This seems to fix it. Basically, if the menubar is 'autohide', set an attrib on main-window that css can pick up on to set the offset at the right time.

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 454758 [details] [diff] [review]
update

Why not something like #main-window[sizemode="maximized"][chromemargin] or #main-window[sizemode="maximized"][chromemargin^="0,"]?

Comment 14

[Jim Mathies [:jimm]]

Attachment: update

Comment 15

[Jim Mathies [:jimm]]

Comment on attachment 454881 [details] [diff] [review]
update

(In reply to comment #13)
> (From update of attachment 454758 [details] [diff] [review])
> Why not something like #main-window[sizemode="maximized"][chromemargin] or
> #main-window[sizemode="maximized"][chromemargin^="0,"]?

tricky, I like the last one. works as expected. Thanks Dao.

Comment 16

[imradyurrad]

Nice. Can this be marked resolved now?

Comment 17

[Jim Mathies [:jimm]]

(In reply to comment #16)
> Nice. Can this be marked resolved now?

Not until I land it on m-c! ;)

Comment 18

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/626decd30ccb