575232 - Custom MySQL port support

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, enhancement)

Description

[François Hodierne]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; fr; rv:1.9.2.4) Gecko/20100611 Firefox/3.6.4
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; fr; rv:1.9.2.4) Gecko/20100611 Firefox/3.6.4

In weave server backend, there is no support of MySQL port different than the default one (ie 3306)

Reproducible: Always

Comment 1

[François Hodierne]

Attachment: patch for MySQL custom port support

Comment 2

[François Hodierne]

Attachment: patch for MySQL custom port support (2nd version)

Comment 3

[Toby Elliott [:telliott]]

Attachment: Patch to do configurable ports

The current proposal will break any install who doesn't update their config file, which isn't desirable for such a common default. This version preserves the correct port for people who don't have an entry in the config file.

Comment 4

[Tarek Ziadé (:tarek)]

we can also add WEAVE_MYSQL_AUTH_PORT in 1.0/default_constants.php.dist as François did initially, for documentation purpose. So people will know that the port is now configurable, when they set up their Sync box.

Comment 5

[Toby Elliott [:telliott]]

Attachment: Revised version including constants file

Comment 6

[Toby Elliott [:telliott]]

Attachment: The version for reg server

Comment 7

[Toby Elliott [:telliott]]

Attachment: The version for internal-reg

Comment 8

[Toby Elliott [:telliott]]

Fixed in 
http://hg.mozilla.org/services/reg-server/rev/828798f908a0
http://hg.mozilla.org/services/reg-server-secure/rev/1de06e35aabe
http://hg.mozilla.org/services/sync-server/rev/55d5049f6eeb