Closed Bug 57524 Opened 24 years ago Closed 23 years ago

[FIX]styleSheet .disabled not reset when <meta> element changes preferred stylesheet [AltSS]

Categories

(Core :: DOM: CSS Object Model, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.0

People

(Reporter: ian, Assigned: bzbarsky)

References

()

Details

(Keywords: dom2, testcase)

Attachments

(2 files)

STEPS TO REPRODUCE Cause the following to happen during a document load: 1. A preferred stylesheet is declared. 2. The default style is set to another title. 3. The new preferred stylesheet is declared. The attached testcase does this with something like these three lines: <style type="text/css" title="Alternate"></style> <meta http-equiv="Default-Style" content="Preferred"> <style type="text/css" title="Preferred"></style> ...where each line corresponds to the respective step above. EXPECTED RESULTS The first stylesheet should be disabled, and the DOM should say it is disabled; the second should be enabled. Thus going to View|Use Stylesheet should show a single bullet next to the last item. ACTUAL RESULTS The first stylesheet is correctly disabled, but the DOM claims that both stylesheets are enabled. That is, the "disabled" attribute of the styleSheet interface is 'false' for both stylesheets. This can be seen in the alternate stylesheets menu as both items are selected. The testcase attempts to show this. The "marked" and "actually" comments should be the same. At the moment, the results read: 1. Alternate Stylesheet (marked ENABLED, actually DISABLED) 2. Preferred Stylesheet (marked ENABLED, actually ENABLED) It _should_ read: 1. Alternate Stylesheet (marked DISABLED, actually DISABLED) 2. Preferred Stylesheet (marked ENABLED, actually ENABLED) ...that is the alternate stylesheet line should say it is marked DISABLED. This works fine if you actually _switch_ (using the menu) to one of the stylesheets. Tested with Windows 2000 commercial branch bits 2000102017 and scc's Mac bits on Thursday night. This bug is visible on scc's restricted access Journal page.
Blocks: html4.01
Component: Layout → DOM Level 2
QA Contact: petersen → ian
Talking this from claytons list, and --> Future
Assignee: clayton → jst
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → Future
Status: NEW → ASSIGNED
(marking alternate style sheet bugs for easy tracking...)
Summary: styleSheet .disabled not reset when <meta> element changes preferred stylesheet → styleSheet .disabled not reset when <meta> element changes preferred stylesheet [ASS]
Summary: styleSheet .disabled not reset when <meta> element changes preferred stylesheet [ASS] → styleSheet .disabled not reset when <meta> element changes preferred stylesheet [AltSS]
Keywords: dom2
Component: DOM Level 2 → DOM Style
Taking QA Contact on all open or unverified DOM Style bugs...
Attached patch Proposed fixSplinter Review
Tell the sheet we're disabling it instead of just disabling.
Comment on attachment 71232 [details] [diff] [review] Proposed fix r=peterv
Attachment #71232 - Flags: review+
taking bug
Assignee: jst → bzbarsky
Status: ASSIGNED → NEW
Priority: P3 → P1
Summary: styleSheet .disabled not reset when <meta> element changes preferred stylesheet [AltSS] → [FIX]styleSheet .disabled not reset when <meta> element changes preferred stylesheet [AltSS]
Target Milestone: Future → mozilla1.0
Comment on attachment 71232 [details] [diff] [review] Proposed fix sr=jst
Attachment #71232 - Flags: superreview+
*** This bug has been marked as a duplicate of 124042 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
um... that was a typo. :)
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment on attachment 71232 [details] [diff] [review] Proposed fix a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #71232 - Flags: approval+
checked in on trunk.
Status: REOPENED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: