57532 - Themes preference panel does not have correct default value

Status: VERIFIED DUPLICATE of bug 54681

(SeaMonkey :: Themes, enhancement, P3)

Description

[Moses Lei]

Bug 51010, case #1 reappears after a period of worksforme. I am using the Modern
skin, but when I go to Preferences\Appearance\Themes, the skin selected is
"Classic." It seems that (although I could be wrong) the first theme is always
selected by default. The correct default should be the current theme.

How to reproduce: Make sure your skin is not classic. then go to
Edit\Preferences, Appearance\Themes (or View\Apply Theme\Theme Preferences)

Actual results: The classic skin will be selected by default.

Expected results: The current skin should be selected.

Running Win32 2000101908, win98. Setting OS to All because this looks like a
"reopen" of bug 51010 case #1.

Comment 1

[sairuh (rarely reading bugmail)]

over to themes.

Comment 2

[timeless]

I don't know if this is a bug, since I don't think we explicitly say the 
selection indicates the current skin. That would be rather hard to do since you 
can have multiple active skins.

For the bare fix this is probably ben's bug, but blake or I could fix it.

Comment 3

[Moses Lei]

Most people will not have more than one active skin. In fact, I did not know
that was possible before you said so. I assume for it to happen you have to poke
into prefs.js or some other config file?

It is a UI standard to have the current item selected, so that if you push
"Apply" nothing should change.

This isn't important for now, probably mozilla1.0 is a good milestone for it.
Not my call though.

Comment 4

[timeless]

Yeah, you might call it an undocumented feature, basically the current prefs ui 
will need to be replaced because it doesn't accurately describe skin selection.

We probably could use a polymorphic widget (w/ at least tree, details and icon 
views) to describe all skinable components (and current state in details), and 
then some sort of theme selector (our current listbox would work, although for 
details the current view could be a combobox).

Generally speaking, anyone can create a package and supply whichever skins they 
like w/ it. Supplying Classic or Modern2 is not required (although it is 
advisable for the time being), Komodo, ThemeBuilder, Jabber are among 
existing/planned xpcom applications. Komodo does ship w/ a classic skin, but 
Jabber most likely will want a wide variety of skins that really don't exist in 
the rest of mozilla.

I guess it would be neat if skins were generic enough so that they could affect 
a class of components instead of a specific instance. eg: Composer, Komodo and 
Vixen can all be used as Development Environments. I would love to be able to 
have a skin built for one of these three that works relatively well on the 
other two, but I might not want that theme to apply to Navigator.

Comment 5

[Eric Y. Theriault]

A bug related to the preferences menu is also the preview.  I'm using build
2000112920, and I've just gone to Netscape.com and installed all the themes that
are available there, however, only the Classic and Modern have a preview.

I sat there previewing each one to get a feel for each, and it the second theme
I applied (without leaving the Preference menu), right after a message box came
up stating that one of my active pages was a form and would require reloading
(To which I answered Cancel both times), crashed.  I've not been able to
reproduce that.

When applying the Modern and the Modern-Mozillium and then reapplying the
Modern, the look was a cross between both.  I had to restart Mozilla in order to
really apply the skin.

Comment 6

[timeless]

Eric Y. Theriault: those are all other issues. Please do not confuse bugs. 
One issue per bug report. Also: please don't hit and run. If you have a comment 
and think it's worth it for others to read, then please stick around to read 
the responses.

Comment 7

[timeless]

*** Bug 53790 has been marked as a duplicate of this bug. ***

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

cc:ing myself.

Comment 9

[Fabian Guisset]

Please see bug 54681 for an explanation.
Fabian.

Comment 10

[Moses Lei]

Marking duplicate of 54681 because the proposed solution there would close this
bug; in addition, the same technical issues are present.

*** This bug has been marked as a duplicate of 54681 ***

Comment 11

[Patty Mac]

Verified dup.