575519 - "make buildsymbols" doesn't work on systems without Visual C++ 2005 installed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jesse Ruderman]

Attachment: log

I'm using Windows 7 and MSVC++ 2008 Express Edition (without ATL).  I built a debug build from mozilla-central, went to the objdir, and typed "make buildsymbols".  It gave me an error message, "zip error: Nothing to do!".


...
Processing file: .\xpcom\windbgdlg\windbgdlg.pdb
echo packing symbols
packing symbols
c:/Users/jruderman/mozilla-central/objdir-ff-debug/config/nsinstall.exe -D ./dist/
cd ./dist/crashreporter-symbols && \
          zip -r9D "../firefox-4.0b2pre.en-US.win32.crashreporter-symbols-full.zip" .
  adding: firefox-4.0b2pre-WINNT-20100628223600-symbols.txt (152 bytes security) (stored 0%)
cd ./dist/crashreporter-symbols && \
          zip -r9D "../firefox-4.0b2pre.en-US.win32.crashreporter-symbols.zip" . -i "*.sym"

zip error: Nothing to do! (../firefox-4.0b2pre.en-US.win32.crashreporter-symbols.zip)
make: *** [buildsymbols] Error 12

Comment 1

[timeless]

sounds like: http://code.google.com/p/airbag/issues/detail?id=114

Comment 2

[(not currently active) Ted Mielczarek]

Try manually running $srcdir/toolkit/crashreporter/tools/win32/dump_syms.exe on a PDB from your objdir, and see what output it produces.

Comment 3

[Jesse Ruderman]

jruderman@JRUDERMAN-XPS ~/mozilla-central/objdir-ff-debug/xpcom/tests
$ ../../../toolkit/crashreporter/tools/win32/dump_syms.exe showalignments.pdb

CoCreateInstance CLSID_DiaSource failed (msdia80.dll unregistered?)
Open failed

Comment 4

[Jesse Ruderman]

I tried with an opt build and still got "zip error: Nothing to do" :(

Comment 5

[(not currently active) Ted Mielczarek]

Ah, yeah. So, the prebuilt dump_syms.exe in the tree uses MSDIA80, which comes with VC 2005. If you don't have VC 2005 Pro installed, it won't work.

Comment 6

[(not currently active) Ted Mielczarek]

Clarifying summary. I sent Jesse a dump_syms.exe built with VC 2008, and it worked for him, so the solution is probably just to add binaries for that (and VC 2010) to the tree and select the right one via configure.

Comment 7

[timeless]

http://www.microsoft.com/downloads/details.aspx?familyid=32BC1BEE-A3F9-4C13-9C99-220B62A191EE&displaylang=en is the redist

ted: we should also add some error handling/reporting so we can recognize this problem

Comment 8

[(not currently active) Ted Mielczarek]

I don't think the redist contains the MSDIA DLLs (but I could be wrong).

Comment 9

[(not currently active) Ted Mielczarek]

Attachment: add a VC9-built dump_syms.exe, choose dump_syms based on compiler version

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 476853 [details] [diff] [review]
add a VC9-built dump_syms.exe, choose dump_syms based on compiler version

This just renames the existing dump_syms binary, adds one built with VC9, and chooses the right one based on the compiler you're using.

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 476853 [details] [diff] [review]
add a VC9-built dump_syms.exe, choose dump_syms based on compiler version

Pretty trivial patch, might fix the Win64 build symbols.

Comment 12

[Carsten Book [:Tomcat]]

maybe we should update https://developer.mozilla.org/en/Building_Firefox_with_Debug_Symbols#Breakpad_symbol_files till this problem is fixed

Comment 13

[LegNeato]

Comment on attachment 476853 [details] [diff] [review]
add a VC9-built dump_syms.exe, choose dump_syms based on compiler version

Approved.

Comment 14

[Carsten Book [:Tomcat]]

ted: can you push this, thanks!

Comment 15

[(not currently active) Ted Mielczarek]

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/4553b507e03a

I also filed bug 623183, which might be a better solution for the future.