"make buildsymbols" doesn't work on systems without Visual C++ 2005 installed

RESOLVED FIXED in mozilla2.0b9

Status

defect
RESOLVED FIXED
9 years ago
a year ago

People

(Reporter: jruderman, Assigned: ted)

Tracking

Trunk
mozilla2.0b9
x86
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Reporter

Description

9 years ago
Posted file log
I'm using Windows 7 and MSVC++ 2008 Express Edition (without ATL).  I built a debug build from mozilla-central, went to the objdir, and typed "make buildsymbols".  It gave me an error message, "zip error: Nothing to do!".


...
Processing file: .\xpcom\windbgdlg\windbgdlg.pdb
echo packing symbols
packing symbols
c:/Users/jruderman/mozilla-central/objdir-ff-debug/config/nsinstall.exe -D ./dist/
cd ./dist/crashreporter-symbols && \
          zip -r9D "../firefox-4.0b2pre.en-US.win32.crashreporter-symbols-full.zip" .
  adding: firefox-4.0b2pre-WINNT-20100628223600-symbols.txt (152 bytes security) (stored 0%)
cd ./dist/crashreporter-symbols && \
          zip -r9D "../firefox-4.0b2pre.en-US.win32.crashreporter-symbols.zip" . -i "*.sym"

zip error: Nothing to do! (../firefox-4.0b2pre.en-US.win32.crashreporter-symbols.zip)
make: *** [buildsymbols] Error 12
Try manually running $srcdir/toolkit/crashreporter/tools/win32/dump_syms.exe on a PDB from your objdir, and see what output it produces.
Reporter

Comment 3

9 years ago
jruderman@JRUDERMAN-XPS ~/mozilla-central/objdir-ff-debug/xpcom/tests
$ ../../../toolkit/crashreporter/tools/win32/dump_syms.exe showalignments.pdb

CoCreateInstance CLSID_DiaSource failed (msdia80.dll unregistered?)
Open failed
Reporter

Comment 4

9 years ago
I tried with an opt build and still got "zip error: Nothing to do" :(
Ah, yeah. So, the prebuilt dump_syms.exe in the tree uses MSDIA80, which comes with VC 2005. If you don't have VC 2005 Pro installed, it won't work.
Clarifying summary. I sent Jesse a dump_syms.exe built with VC 2008, and it worked for him, so the solution is probably just to add binaries for that (and VC 2010) to the tree and select the right one via configure.
Summary: "make buildsymbols" doesn't work for me on Windows: "zip error: Nothing to do!" → "make buildsymbols" doesn't work on systems without Visual C++ 2005 installed

Comment 7

9 years ago
http://www.microsoft.com/downloads/details.aspx?familyid=32BC1BEE-A3F9-4C13-9C99-220B62A191EE&displaylang=en is the redist

ted: we should also add some error handling/reporting so we can recognize this problem
I don't think the redist contains the MSDIA DLLs (but I could be wrong).
Blocks: 580623
Comment on attachment 476853 [details] [diff] [review]
add a VC9-built dump_syms.exe, choose dump_syms based on compiler version

This just renames the existing dump_syms binary, adds one built with VC9, and chooses the right one based on the compiler you're using.
Attachment #476853 - Flags: review?(mitchell.field)
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #476853 - Flags: review?(mitchell.field) → review+
Blocks: 618385
Comment on attachment 476853 [details] [diff] [review]
add a VC9-built dump_syms.exe, choose dump_syms based on compiler version

Pretty trivial patch, might fix the Win64 build symbols.
Attachment #476853 - Flags: approval2.0?

Comment 13

9 years ago
Comment on attachment 476853 [details] [diff] [review]
add a VC9-built dump_syms.exe, choose dump_syms based on compiler version

Approved.
Attachment #476853 - Flags: approval2.0? → approval2.0+
ted: can you push this, thanks!
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/4553b507e03a

I also filed bug 623183, which might be a better solution for the future.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.