Closed
Bug 580623
Opened 14 years ago
Closed 14 years ago
(enable crashreporter for Win64 builds) symbol server lacks symbols for x64 builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: timeless, Assigned: ted)
References
Details
Attachments
(1 file)
634 bytes,
patch
|
Mitch
:
review+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
people have started to use 64bit builds of mozilla on windows. our general instructions to people who have crashes is to use windbg which uses the symbol server. without symbols on the symbol server, the result is bad.
the users get upset and i get upset and everyone gets upset.
getting breakpad working is unrelated, as pushed symbols can be used by windbg.
Assignee | ||
Comment 1•14 years ago
|
||
Enabling Breakpad in configure should be as simple as fixing the case statement here to include x86-64:
http://mxr.mozilla.org/mozilla-central/source/configure.in#6119
Breakpad basically worked on 64-bit Windows last I checked (since all the dumping is done via DbgHelp.dll anyway), we just don't dump the frame data (bug 548035), so we won't get anything but the tops of stacks on the server-side.
But it should make "buildsymbols/uploadsymbols" work, anyway, which would get you symbol server support.
Assignee | ||
Updated•14 years ago
|
Summary: please start packaging pdb files for w64 → enable reporter for Win64 builds
Assignee | ||
Updated•14 years ago
|
Summary: enable reporter for Win64 builds → enable crashreporter for Win64 builds
Comment 2•14 years ago
|
||
(make me searchable in bugzilla)
could have used x64 symbols this weekend
OS: Mac OS X → All
Hardware: x86 → x86_64
Summary: enable crashreporter for Win64 builds → (enable crashreporter for Win64 builds) symbol server lacks symbols for x64 builds
Assignee | ||
Comment 3•14 years ago
|
||
The Win64 build machines don't have VC 2005 installed, so we'll need to fix bug 575519 first.
Assignee | ||
Comment 4•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #476854 -
Flags: review?(mitchell.field)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Updated•14 years ago
|
Attachment #476854 -
Flags: review?(mitchell.field) → review+
Comment on attachment 476854 [details] [diff] [review]
enable crashreporter on Win64
not having this causes headaches each time i encounter a 64bit crash
Attachment #476854 -
Flags: approval2.0?
Assignee | ||
Comment 6•14 years ago
|
||
Note that we probably need bug 575519 to land as well.
Drivers: this patch should have zero impact on anything but Win64 builds.
Comment 7•14 years ago
|
||
Comment on attachment 476854 [details] [diff] [review]
enable crashreporter on Win64
a=beltzner
Attachment #476854 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 8•14 years ago
|
||
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/34e60b925a1b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•