Closed Bug 575956 Opened 15 years ago Closed 14 years ago

Customize Address Book toolbars

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a3

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Other parts of SM have customizable toolbars so AB should too.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attached patch WIP patch (obsolete) — Splinter Review
This is very much WIP Still need to move default buttons out of the palette, do CSS work and find out why the customization doesn't work
Attached patch Customizable toolbar patch v0.1 (obsolete) — Splinter Review
This patch: * Makes toolbar in the address book customizable I've tried having the default icons outside of the toolbarpalette but you just end up with icons you cannot move from the toolbar.
Attachment #455194 - Attachment is obsolete: true
Attachment #455282 - Flags: review?(philip.chee)
(In reply to comment #2) > Created an attachment (id=455282) [details] > Customizable toolbar patch v0.1 > > This patch: > * Makes toolbar in the address book customizable > > I've tried having the default icons outside of the toolbarpalette but you just > end up with icons you cannot move from the toolbar. Oh I also changed the id for delete to make it unique.
Comment on attachment 455282 [details] [diff] [review] Customizable toolbar patch v0.1 Bug 575956 - Customize Address Book toolbars > I've tried having the default icons outside of the toolbarpalette but you just > end up with icons you cannot move from the toolbar. Strange. That's what Minefield does. I wonder what we/they are doing differently. > Oh I also changed the id for delete to make it unique. Unique in what sense? FYI Thunderbird uses "button-abdelete" > + <toolbar type="menubar" > + id="ab-toolbar-menubar2" Thunderbird uses: "addrbook-toolbar-menubar2" Too verbose, but I suppose Mnyromyr will insist on following Thunderbird slavishly. > + <menubar id="ab-menubar"> Thunderbird uses: "mail-menubar" Too generic I fear. Perhaps Thunderbird should change instead of us? > + <toolbar class="chromeclass-toolbar toolbar-primary" > + id="abToolbar" Thunderbird->"ab-bar2". Sigh. > + <toolbaritem id="searchBox" Thunderbird uses "search-container". *We* use "search-container" in mailnews (IIRC it was your patch too). Note must change the .js as well. However it is unclear why Thunderbird increased the timeout to 800ms though. > + <toolbaritem id="throbber-box" align="center"> In small icon mode (e.g. move it to the menubar) the background should be removed e.g. { background: none; }. Bonus do it for the main mailnews window as well. Unfortunately you will have to remove the list-style-image from .toolbarbutton-1 > .toolbarbutton-1 { > list-style-image: url("chrome://messenger/skin/addressbook/icons/addressbookicons.png"); > } And apply it to each individual button. See the Thunderbird /skin/addressbook.css for example. > -#button-delete { > +#button-delete-item { list-style-image: url("chrome://messenger/skin/addressbook/icons/addressbookicons.png"); > -moz-image-region: rect(0 29px 29px 0); > } Please file bugs in classic and in modern for adding small toolbar icons to the Addressbook. For classic a suitable image resizing tool on the existing large icons would do. Modern would need completely new images.
Attachment #455282 - Flags: review?(philip.chee) → review-
Blocks: 576402
Blocks: 576403
Attached patch Customizable toolbar patch v0.1a (obsolete) — Splinter Review
Changes since v0.1: * Renamed id "ab-toolbar-menubar2" to "addrbook-toolbar-menubar2" * Renamed id "abToolbar" to "ab-bar2" * throbber-box for small icon toolbars now has no background on modern * Removed the list-style-image from .toolbarbutton-1 * Added list-style-image, where relevant, to the individual buttons Tried having one button still left in the palette and that was the only button that could be moved, all the rest were locked in place. Left "ab-menubar" and "searchBox" ids alone so that they are unique in SM.
Attachment #455282 - Attachment is obsolete: true
Attachment #455595 - Flags: review?(philip.chee)
Comment on attachment 455595 [details] [diff] [review] Customizable toolbar patch v0.1a Looks good.
Attachment #455595 - Flags: review?(philip.chee) → review+
>> I've tried having the default icons outside of the toolbarpalette but you just >> end up with icons you cannot move from the toolbar. > > Strange. That's what Minefield does. I wonder what we/they are doing > differently. A closer reading of Bug 354048 indicates that we need to add |removable="true"| to those items that are already on a toolbar. Items in the palette automatically gain this attribute when moved to a toolbar.
Changes since v0.1a: * Make use of |removable="true"|
Attachment #455595 - Attachment is obsolete: true
Attachment #456965 - Flags: superreview?(bugzilla)
Attachment #456965 - Flags: review?(philip.chee)
Comment on attachment 456965 [details] [diff] [review] Customizable toolbar with removable patch v0.1b [Checkin: Comment 13] Looks good. r=me
Attachment #456965 - Flags: review?(philip.chee) → review+
(In reply to comment #9) > Comment on attachment 456965 [details] [diff] [review] > Customizable toolbar with removable patch v0.1b > > Looks good. r=me Just as a note I have one additional local change of <popup> to <menupopup>
Attachment #456965 - Flags: superreview?(bugzilla) → superreview?(neil)
(In reply to comment #4) > > + <toolbar class="chromeclass-toolbar toolbar-primary" > > + id="abToolbar" > Thunderbird->"ab-bar2". Sigh. [Double sigh. Who was responsible for that id?]
Comment on attachment 456965 [details] [diff] [review] Customizable toolbar with removable patch v0.1b [Checkin: Comment 13] >+toolbar:not([iconsize="small"]) #throbber-box { We only want the override to apply when the toolbar has a line, which is the specific case where the throbber is in a default primary non-navigator toolbar. So you either need to use .toolbar-primary:not([labelalign="end"]):not(etc.) or you need to override the background to transparent in each of the cases where toolbar.css overrides the line plus either way you also need to override the background to transparent in navigator.css which turns the line off anyway.
Attachment #456965 - Flags: superreview?(neil) → superreview+
Comment on attachment 456965 [details] [diff] [review] Customizable toolbar with removable patch v0.1b [Checkin: Comment 13] http://hg.mozilla.org/comm-central/rev/6368a42a985a Pushed with popup->menupopup and css rule change.
Attachment #456965 - Attachment description: Customizable toolbar with removable patch v0.1b → Customizable toolbar with removable patch v0.1b [Checkin: Comment 13]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
Depends on: 882178
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: