882178 - Fix navigation toolbar problems in small-icons mode (toolbar and throbber background).

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Philip Chee]

From Bug #526210 Comment 16 Matt A. Tobin wrote:

> --- ISSUE: when in small icons mode on the navigation toolbar the background 
> goes from a gradient to a solid color and the throbber box has a background
> 
> --- SOLUTION (done): Apply the background to the small icons mode and reenforce 
> no background on the throbber box with an !important decoration.
>

Comment 1

[Philip Chee]

Attachment: Patch 1.0 based on fix by Matt A. Tobin

Comment 2

[rsx11m]

Why did you mark this as "meta" in the keywords?
Looks like you're solving a single issue here.

Comment 3

[Philip Chee]

> Why did you mark this as "meta" in the keywords?
oops clone copies too much data over.

Comment 4

[[e-mail]]

Comment on attachment 761510 [details] [diff] [review]
Patch 1.0 based on fix by Matt A. Tobin

> #nav-bar[iconsize="small"] > .toolbar-primary-holder {
>-  background: #D0D7DF;
>+  background-color: #D0D7DF;
> }
Not sure why this was ever here (it dates to bug 68136) but there's no point just changing the colour, you might as well remove the style completely.

>+.toolbar-primary #throbber-box,
No idea what the point of this is supposed to be.

Comment 5

[Matt A. Tobin]

If I recall correctly the throbber needs a background in mailnews for that line between the icon and the text labels to make it stop. I will have to check to see if that piece of code is for that or not. Will report back.

Comment 6

[Philip Chee]

Attachment: Patch v1.1 Remove toolbar-primary-holder rule completely

>> #nav-bar[iconsize="small"] > .toolbar-primary-holder {
>>-  background: #D0D7DF;
>>+  background-color: #D0D7DF;
>> }
> Not sure why this was ever here (it dates to bug 68136) but there's no point
> just changing the colour, you might as well remove the style completely.
Fixed.

>>+.toolbar-primary #throbber-box,
> No idea what the point of this is supposed to be.

In modern/communicator/brand.css we have:

> .toolbar-primary #throbber-box {
>   background: url("chrome://communicator/skin/toolbar/prtb-bg-noline.gif") #B1BDC9 repeat-x top;
> }

This isn't noticeable in large icon mode (or icon+text) because the primary-toolbar-holder also has the same background image.
In small icon mode the background image on the toolbar-holder is gone so the background image on the throbber-box clashes.
Removing the first hunk completely:

>- #nav-bar[iconsize="small"] > .toolbar-primary-holder {
>-   background: #D0D7DF;
 
And the background images match again.

>>+.toolbar-primary #throbber-box,
> No idea what the point of this is supposed to be.

This turns off the background image on the throbber box and relies on the primary-toolbar-holder background.

> .toolbar-primary #throbber-box,
> #throbber-box {
>   background: none; /* override bg used to cover toolbar line */
>   margin: 0px 0px 2px;
> }

This bit isn't necessary but it's tidying up a loose end.

Comment 7

[[e-mail]]

(In reply to Philip Chee from comment #6)
> (In reply to comment #4)
> > (From update of attachment 761510 [details] [diff] [review])
> > >+.toolbar-primary #throbber-box,
> > No idea what the point of this is supposed to be.
> This turns off the background image on the throbber box and relies on the
> primary-toolbar-holder background.
Ah, so what happened here is that bug 575956 changed the background image rule to only affect the throbber box on the primary toolbar, but navigator.css was never updated. The correct fix is to change the rule, not add a new one.

Comment 8

[[e-mail]]

Comment on attachment 761954 [details] [diff] [review]
Patch v1.1 Remove toolbar-primary-holder rule completely

> /* ::::: navigator throbber ::::: */
> 
>+.toolbar-primary #throbber-box,
> #throbber-box {
r=me with the rule edited instead of added.

Comment 9

[Philip Chee]

Attachment: Patch v1.2 (Original fix by Matt A. Tobin) for check-in r=Neil [check-in Comment 12]

>>+.toolbar-primary #throbber-box,
>> #throbber-box {
> r=me with the rule edited instead of added.
Fixed.

Comment 10

[Matt A. Tobin]

Comment on attachment 762046 [details] [diff] [review]
Patch v1.2 (Original fix by Matt A. Tobin) for check-in r=Neil [check-in Comment 12]

Review of attachment 762046 [details] [diff] [review]:
-----------------------------------------------------------------

This current version of the patch seems to fix the navibar/throbber issues as described. I am happy with it.

Comment 11

[Matt A. Tobin]

Attachment: Real World Screenshot Shows Fixed as Described

Comment 12

[Philip Chee]

Comment on attachment 762046 [details] [diff] [review]
Patch v1.2 (Original fix by Matt A. Tobin) for check-in r=Neil [check-in Comment 12]

Pushed to comm-central a=Callek CLOSED TREE