Closed
Bug 576151
Opened 16 years ago
Closed 16 years ago
Better message for leftover tabs and windows on timed out browser-chrome tests
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b2
People
(Reporter: mak, Assigned: mak)
Details
Attachments
(1 file, 2 obsolete files)
|
2.22 KB,
patch
|
Details | Diff | Splinter Review |
Actually we confused some timeout with bug 573779 because the harness was complaining about open tabs. If a test times out it is pretty obvious it could have left something behind, then we should just close tabs and windows and move on. The timeout error is what we care about.
| Assignee | ||
Comment 1•16 years ago
|
||
I ended up clicking enter too early. patch is untested, just a PoC
| Assignee | ||
Updated•16 years ago
|
Assignee: nobody → mak77
| Assignee | ||
Comment 2•16 years ago
|
||
Actually I fear that removing that information will make timeouts harder to debug. For example yesterday the tab left open was about:addons and indeed the patches causing the timeout were related to addons.
So the alternative is changing the message.
"Found a tab after previous test timed out: uri" should clarify the reason.
Attachment #455441 -
Flags: review?(gavin.sharp)
Comment 3•16 years ago
|
||
Comment on attachment 455441 [details] [diff] [review]
alternative patch
>diff --git a/testing/mochitest/browser-test.js b/testing/mochitest/browser-test.js
> waitForWindowsState: function Tester_waitForWindowsState(aCallback) {
>+ let timedOut = this.currentTest && "timedOut" in this.currentTest;
can just be this.currentTest && this.currentTest.timedOut
Attachment #455441 -
Flags: review?(gavin.sharp) → review+
| Assignee | ||
Updated•16 years ago
|
Summary: Don't complain about open tabs or open windows if previous test timed out → Better message for leftover tabs and windows on timed out browser-chrome tests
| Assignee | ||
Comment 4•16 years ago
|
||
Attachment #455320 -
Attachment is obsolete: true
Attachment #455441 -
Attachment is obsolete: true
| Assignee | ||
Comment 5•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b2
Updated•8 years ago
|
Component: BrowserTest → Mochitest
You need to log in
before you can comment on or make changes to this bug.
Description
•