576220 - test_history_sidebar.js | 8 == 9 - unit test failure

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect, P3)

Description

[Doug Turner (:dougt)]

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/mozilla-central-fedora64-opt-u-xpcshell/build/xpcshell/tests/test_places/unit/test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
  >>>>>>>
  TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-PASS | /home/cltbld/talos-slave/mozilla-central-fedora64-opt-u-xpcshell/build/xpcshell/tests/test_places/unit/head_bookmarks.js -> file:///home/cltbld/talos-slave/mozilla-central-fedora64-opt-u-xpcshell/build/xpcshell/tests/test_places/head_common.js | [check_no_bookmarks : 283] 0 == 0

Comment 1

[Doug Turner (:dougt)]

Maybe related to 552386 (which is fixed)

I did verify that the fix is still in m-c after the e10s merge.

Comment 2

[Legacy TBPL/Treeherder Robot]

dougt
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1277969470.1277971569.16280.gz
Rev3 Fedora 12 mozilla-central debug test xpcshell on 2010/07/01 00:31:10

s: talos-r3-fed-049
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/mozilla-central-fedora-debug-u-xpcshell/build/xpcshell/tests/test_places/unit/test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/mozilla-central-fedora-debug-u-xpcshell/build/xpcshell/tests/test_places/unit/test_history_sidebar.js | 8 == 9 - See following stack:

Comment 3

[Marco Bonardo [:mak]]

hum, really strange, has started with a changeset at Wed Jun 30 21:48:27 2010 PDT
the older than 6 months container is missing. Some calculation issue with February duration?

Comment 4

[Marco Bonardo [:mak]]

I don't think this is a DST problem, so should be unrelated to other fixes.

Comment 5

[Marco Bonardo [:mak]]

the problem has stopped around Wed Jun 30 23:28:42 2010 PDT

Comment 6

[Marco Bonardo [:mak]]

could have been fixed (on places branch so far) by bug 603002, but it's hard to verify

Comment 7

[Marco Bonardo [:mak]]

marking as fixed since the underlying bug is fixed, reopen if you still notice it (in case there were more than 1 problems)

Comment 8

[Jonathan Kew [:jfkthame]]

This just started happening again: as soon as we crossed midnight from June 30 / July 1 (PST), every xpcshell test on m-c is failing with this error. Removing the "[fixed by bug 603002]' annotation as it does not appear to be truly fixed.

Comment 9

[Legacy TBPL/Treeherder Robot]

jfkthame%gmail.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1309504606.1309506528.25443.gz
Rev3 Fedora 12x64 mozilla-central debug test xpcshell on 2011/07/01 00:16:46

s: talos-r3-fed64-028
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | 8 == 9 - See following stack:

Comment 10

[Legacy TBPL/Treeherder Robot]

jfkthame%gmail.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1309504709.1309507482.30508.gz
Rev3 WINNT 5.1 mozilla-central debug test xpcshell on 2011/07/01 00:18:29

s: talos-r3-xp-019
TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\tests\toolkit\components\places\tests\unit\test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | c:/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | 8 == 9 - See following stack:

Comment 11

[Legacy TBPL/Treeherder Robot]

chris%pearce.org.nz
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1309506217.1309508841.4438.gz
Rev3 WINNT 6.1 mozilla-inbound opt test xpcshell on 2011/07/01 00:43:37

s: talos-r3-w7-035
TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\tests\toolkit\components\places\tests\unit\test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | c:/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | 8 == 9 - See following stack:

Comment 12

[Legacy TBPL/Treeherder Robot]

chris%pearce.org.nz
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1309506196.1309508582.2733.gz
Rev3 Fedora 12x64 mozilla-inbound debug test xpcshell on 2011/07/01 00:43:16

s: talos-r3-fed64-004
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | 8 == 9 - See following stack:

Comment 13

[Legacy TBPL/Treeherder Robot]

mak77%bonardo.net
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1309503455.1309506795.26469.gz
Rev3 WINNT 6.1 mozilla-inbound debug test xpcshell on 2011/06/30 23:57:35

s: talos-r3-w7-015
TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\tests\toolkit\components\places\tests\unit\test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | c:/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | 8 == 9 - See following stack:

Comment 14

[Legacy TBPL/Treeherder Robot]

m_kato%ga2.so-net.ne.jp
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1309503455.1309506795.26469.gz
Rev3 WINNT 6.1 mozilla-inbound debug test xpcshell on 2011/06/30 23:57:35

s: talos-r3-w7-015
TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\tests\toolkit\components\places\tests\unit\test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | c:/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | 8 == 9 - See following stack:

Comment 15

[Geoff Lankow (:darktrojan)]

Attachment: patch

This patch eliminates the faulty test in two ways, (1) removing the DST handling code, and (2) aiming for a date in the middle of the month instead of near the end.

Still not sure why it only affects July 1 though. Might be a February issue?

Comment 16

[Geoff Lankow (:darktrojan)]

Comment on attachment 543396 [details] [diff] [review]
patch

You're right Marco, this is a dumb idea. And in any case I've found a real bug.

Comment 17

[Geoff Lankow (:darktrojan)]

Okay, here's the real bug, since I wasted my time figuring it out:

July 1 before 0100, minus an hour for DST (Northern Hemisphere only), is June 30
January 31 to June 30 is 150 days

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsNavHistory.cpp#176

When _daysFromOldestVisit is 150, this macro returns 5 instead of 6 that we're expecting.

Thus January 31, in extremely limited circumstances, is a part of February.

Comment 18

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=24773979&tree=Mozilla-B2g18
Rev3 WINNT 6.1 mozilla-b2g18 pgo test xpcshell on 2013-06-30 23:50:52
revision: f76cd1f0a5e9
slave: talos-r3-w7-111

TEST-UNEXPECTED-FAIL | C:\talos-slave\test\build\xpcshell\tests\toolkit\components\places\tests\unit\test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | 8 == 9 - See following stack:

Comment 19

[Stephanie Cunnane [:scunnane]]

Since this hasn't failed in the past 10 years, so we'll resolve this as WORKSFORME.