Closed Bug 603002 Opened 9 years ago Closed 9 years ago

History folders labelled with wrong month names

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b9

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fixed-in-places])

Attachments

(1 file)

It's October 9. In my history I have folders for:

* Today (Oct 9)
* Yesterday (Oct 8)
* Last 7 days (Oct 2 - 9, surely that's 8 days but whatever)
* This month (Oct 1 - 9)
* August

The entry for August contains my history for September, which is as far back as my history goes.

This also happens in my Firefox 3.6 profile, it has folders for April - August which contain May - September's history.
Now that it's past midnight UTC the months are labelled correctly. Is there something funky going on when the local date is greater than the UTC date? (I'm 13 hours ahead here.)
there is most likely still some wrong calculation on the start/end of months.
Btw, which version are we talking about? latest nightly? latest beta?
(In reply to comment #2)
> there is most likely still some wrong calculation on the start/end of months.
> Btw, which version are we talking about? latest nightly? latest beta?

Neither - I build from source about once a week.

I've just checked Firefox 3.6 on Windows and Ubuntu, and they both have this bug.
Attached patch patchSplinter Review
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #484110 - Flags: review?(mak77)
Comment on attachment 484110 [details] [diff] [review]
patch

ah, interesting! many thanks for findind the bug, appreciate that.

I guess if these timezone+DST bugs will ever end :(

Asking approval because the patch is really small and pretty much safe, writing a test for this edge case would be quite tricky and orange-prone since it involves specific timezones and corrections, thus I'm not requesting it.
Attachment #484110 - Flags: review?(mak77)
Attachment #484110 - Flags: review+
Attachment #484110 - Flags: approval2.0?
Attachment #484110 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
I'll land this in Places since it would bitrot our current work on central.
Keywords: checkin-needed
http://hg.mozilla.org/projects/places/rev/debf742b7265

thanks again.
Whiteboard: [fixed-in-places]
Blocks: 576220
http://hg.mozilla.org/mozilla-central/rev/debf742b7265
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9
You need to log in before you can comment on or make changes to this bug.