Qualify accesses to dependent base in js

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: Eli Friedman, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 455539 [details] [diff] [review]
Patch

Patch attached.  Similar to bug 573210, but in js/src/.  See bug 573210 comment 6 for an explanation of why clang isn't accepting code gcc does accept.
Attachment #455539 - Flags: review?(brendan)
Note different module (and repo -- nanojit-central) from JS engine proper.

/be
Assignee: sharparrow1 → nobody
Component: JavaScript Engine → Nanojit
OS: Linux → All
QA Contact: general → nanojit
Hardware: x86 → All
Attachment #455539 - Flags: review?(brendan) → review?(nnethercote)
Comment on attachment 455539 [details] [diff] [review]
Patch

The change appears fine, I'll take your word that it fixes the relevant problem when compiling with clang.

Eli, do you want me to land this patch for you?
Attachment #455539 - Flags: review?(nnethercote) → review+
(Reporter)

Comment 3

8 years ago
Yes, please.(In reply to comment #2)
> Eli, do you want me to land this patch for you?

Yes, please.
http://hg.mozilla.org/tracemonkey/rev/adce1efdf651
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/adce1efdf651
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 7

8 years ago
TR: http://hg.mozilla.org/tamarin-redux/rev/2330f7d69b58
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
(Assignee)

Updated

4 years ago
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.