Closed Bug 576363 Opened 10 years ago Closed 10 years ago

Qualify accesses to dependent base in js

Categories

(Core Graveyard :: Nanojit, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sharparrow1, Unassigned)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)

Attachments

(1 file)

Attached patch PatchSplinter Review
Patch attached.  Similar to bug 573210, but in js/src/.  See bug 573210 comment 6 for an explanation of why clang isn't accepting code gcc does accept.
Attachment #455539 - Flags: review?(brendan)
Note different module (and repo -- nanojit-central) from JS engine proper.

/be
Assignee: sharparrow1 → nobody
Component: JavaScript Engine → Nanojit
OS: Linux → All
QA Contact: general → nanojit
Hardware: x86 → All
Attachment #455539 - Flags: review?(brendan) → review?(nnethercote)
Comment on attachment 455539 [details] [diff] [review]
Patch

The change appears fine, I'll take your word that it fixes the relevant problem when compiling with clang.

Eli, do you want me to land this patch for you?
Attachment #455539 - Flags: review?(nnethercote) → review+
Yes, please.(In reply to comment #2)
> Eli, do you want me to land this patch for you?

Yes, please.
http://hg.mozilla.org/tracemonkey/rev/adce1efdf651
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/adce1efdf651
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
TR: http://hg.mozilla.org/tamarin-redux/rev/2330f7d69b58
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.