576408 - Implement the downgraded tab triage experience.

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Aza Raskin [:aza]]

Please see https://wiki.mozilla.org/Firefox/Projects/TabCandy/Design/Triage

Note, this bug is for creating the downgraded triage experience, not the full triage experience. That is in a follow up bug. That does mean there will be no way in this iteration to move a tab to an unnamed group via the triage interface.

Upon selected a group from the menu, the tab disappears from the current tab strip and is moved to the appropriate group.

Comment 1

[Raymond Lee [:raymondlee]]

Aza/Ian: please check the behaviour.
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/42757fc4edcc

Comment 2

[Ian Gilman [:iangilman]]

Looks good. One minor nit: the spec had "Named Groups" in the menu, and you've got "Named Group". 

Also, perhaps the "named groups" label shouldn't exist unless there are groups to select?

Comment 3

[Matthew Galloway]

More of a suggestion than a bug;
I like this idea. However, I'm not sure if using a right (or option) clicking a tab and using menu is the right way of going about it. I would think that using the same ctrl+space combination again to quickly shuttle things around be the best option. 

How I would do it:
ctrl+space works as expected, provide you just press the keys momentarily. However, if you hold down that combination, the active tab would dim and a miniature version of the visual tab interface (identical to the one that was planed for the full triage experience) would show up beneath the cursor (or in the center of the window, either way) so that the user could select what group to put the tab in. 

Expected benefits:
- Same spatial memory benefits as the full tab interface
- Same usage familiarity to alt-tab (apple-tab)
- Faster than moving all the way to the top of the screen and going through a menu

At the very least:
Add the "Move this tab to" option to the in-window right click menu.

Comment 4

[imradyurrad]

Dependent on bug 566510?

Comment 5

[Raymond Lee [:raymondlee]]

(In reply to comment #2)
> Looks good. One minor nit: the spec had "Named Groups" in the menu, and you've
> got "Named Group". 
> 
> Also, perhaps the "named groups" label shouldn't exist unless there are groups
> to select?

Fixed the typo and "Named Groups" label is hidden if there isn't any groups to select.
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/5ff313be6adb

Re-assigning to aza for his feedback on  comment 3

Comment 6

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 7

[Ian Gilman [:iangilman]]

This has been fixed for a while; resolving.  If we want to pursue comment 3, we should do it in another bug.

Comment 8

[Tracy Walker [:tracy]]

verified on recent nightly builds of minefield