Closed
Bug 576435
Opened 15 years ago
Closed 11 years ago
ASSERTION: How can this ever happen?: '*aUnconstrainedSize <= scriptLevelSize'
Categories
(Core :: MathML, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jruderman, Assigned: away)
References
Details
(Keywords: assertion, testcase)
Attachments
(1 file)
|
2.19 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
On Windows only, layout/style/crashtests/413274-1.xhtml triggers:
###!!! ASSERTION: How can this ever happen?: '*aUnconstrainedSize <= scriptLevelSize', file layout/style/nsRuleNode.cpp, line 2650
###!!! ASSERTION: scriptminsize should never be making things bigger: 'aFont->mScriptUnconstrainedSize <= aFont->mSize', file layout/style/nsRuleNode.cpp, line 3087
Flags: in-testsuite+
From the duplicate:
What this boils down to is that on 32-bit Windows, NSToCoordRound(nscoord_MAX) is negative, despite the assurances in NS_lroundup30: http://hg.mozilla.org/mozilla-central/annotate/c482c28b35b6/xpcom/ds/nsMathUtils.h#l38
We talked about removing NS_lroundup30 completely, but I'm scared to undo that perf shortcut, since the regular MSVC code for it is still yucky these days.
How about this instead?
Attachment #8444326 -
Flags: review?(roc)
Comment on attachment 8444326 [details] [diff] [review]
Use NSToCoordRoundWithClamp instead of clamping by hand
Review of attachment 8444326 [details] [diff] [review]:
-----------------------------------------------------------------
definitely!
Attachment #8444326 -
Flags: review?(roc) → review+
|
||
Comment 6•11 years ago
|
||
Assignee: nobody → dmajor
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•