Closed Bug 576831 Opened 10 years ago Closed 10 years ago

Remove nsICSSStyleRule

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: craig.topper, Assigned: craig.topper)

References

(Blocks 1 open bug)

Details

Attachments

(6 files, 20 obsolete files)

12.70 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
8.38 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
3.62 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
85.22 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
5.22 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
6.33 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
This interface is only implemented by one class so there is no reason for it to exist.
Attached patch Part 1: Rename CSSStyleRuleImpl (obsolete) — Splinter Review
Attachment #455923 - Flags: review?(dbaron)
Blocks: deCOM
Attachment #455924 - Flags: review?(dbaron)
Attached patch Part 3: Rename CSSImportantRule (obsolete) — Splinter Review
Attachment #455925 - Flags: review?(dbaron)
Attachment #455926 - Flags: review?(dbaron)
Attachment #455928 - Flags: review?(dbaron)
Attachment #455928 - Attachment is patch: true
Attachment #455928 - Attachment mime type: application/octet-stream → text/plain
Attachment #455957 - Flags: review?(dbaron)
Patches depend on patches in bug 575901 and bug 571946
Depends on: 571946, 575901
Blocks: 577976
Attachment #455923 - Flags: review?(dbaron) → review?(bzbarsky)
Attachment #455924 - Flags: review?(dbaron) → review?(bzbarsky)
Attachment #455925 - Flags: review?(dbaron) → review?(bzbarsky)
Attachment #455926 - Flags: review?(dbaron) → review?(bzbarsky)
Attachment #455928 - Flags: review?(dbaron) → review?(bzbarsky)
Attachment #455957 - Flags: review?(dbaron) → review?(bzbarsky)
Comment on attachment 455923 [details] [diff] [review]
Part 1: Rename CSSStyleRuleImpl

r=bzbarsky
Attachment #455923 - Flags: review?(bzbarsky) → review+
Comment on attachment 455924 [details] [diff] [review]
Part 2: rename DOMCSSStyleRuleImpl

r=bzbarsky
Attachment #455924 - Flags: review?(bzbarsky) → review+
Though it's worth double-checking with dbaron on these renames.  Maybe we want to just drop both the "ns" prefix and the "Impl" suffix and stick these in mozilla::css?
Comment on attachment 455925 [details] [diff] [review]
Part 3: Rename CSSImportantRule

r=bzbarsky, with the caveat above.
Attachment #455925 - Flags: review?(bzbarsky) → review+
Comment on attachment 455928 [details] [diff] [review]
Part 5: Remove virtual from methods that came from nsICSSStyleRule

r=bzbarsky
Attachment #455928 - Flags: review?(bzbarsky) → review+
Comment on attachment 455957 [details] [diff] [review]
Part 6: DeCOMtaminate the methods that came from nsICSSStyleSheet

r=bzbarsky
Attachment #455957 - Flags: review?(bzbarsky) → review+
(In reply to comment #10)
> Though it's worth double-checking with dbaron on these renames.  Maybe we want
> to just drop both the "ns" prefix and the "Impl" suffix and stick these in
> mozilla::css?

We probably do, but I don't think it needs to happen here.  This is an improvement over the current state.
Attachment #455926 - Flags: review?(bzbarsky)
Old patch didn't apply anymore so I went ahead and added namespace.
Attachment #461798 - Flags: review?(bzbarsky)
Attachment #455923 - Attachment is obsolete: true
Attachment #461798 - Attachment description: 455923: Part 1: Rename CSSStyleRuleImpl updated to use namespace → Part 1: Rename CSSStyleRuleImpl updated to use namespace
Attachment #455924 - Attachment is obsolete: true
Attachment #461799 - Flags: review?(bzbarsky)
Attachment #461799 - Attachment is obsolete: true
Attachment #461800 - Flags: review?(bzbarsky)
Attachment #461799 - Flags: review?(bzbarsky)
Attachment #461800 - Attachment description: 461799: Part 2: rename DOMCSSStyleRuleImpl updated to use namespace. → Part 2: rename DOMCSSStyleRuleImpl updated to use namespace.
Attachment #461801 - Flags: review?(bzbarsky)
Attachment #455925 - Attachment is obsolete: true
Attachment #461801 - Attachment is obsolete: true
Attachment #461801 - Flags: review?(bzbarsky)
Attachment #461803 - Flags: review?(bzbarsky)
Attachment #455926 - Attachment is obsolete: true
Attachment #461804 - Flags: review?(bzbarsky)
Attachment #455928 - Attachment is obsolete: true
Attachment #461805 - Flags: review?(bzbarsky)
Attachment #455957 - Attachment is obsolete: true
Attachment #461807 - Flags: review?(bzbarsky)
Updating for bitrot
Attachment #461798 - Attachment is obsolete: true
Attachment #468220 - Flags: review?(bzbarsky)
Attachment #461798 - Flags: review?(bzbarsky)
Attachment #461800 - Attachment is obsolete: true
Attachment #468221 - Flags: review?(bzbarsky)
Attachment #461800 - Flags: review?(bzbarsky)
Attachment #461803 - Attachment is obsolete: true
Attachment #468222 - Flags: review?(bzbarsky)
Attachment #461803 - Flags: review?(bzbarsky)
Attachment #461804 - Attachment is obsolete: true
Attachment #468223 - Flags: review?(bzbarsky)
Attachment #461804 - Flags: review?(bzbarsky)
Attachment #461805 - Attachment is obsolete: true
Attachment #468224 - Flags: review?(bzbarsky)
Attachment #461805 - Flags: review?(bzbarsky)
Attachment #461807 - Attachment is obsolete: true
Attachment #468225 - Flags: review?(bzbarsky)
Attachment #461807 - Flags: review?(bzbarsky)
Attachment #468220 - Attachment is obsolete: true
Attachment #518272 - Flags: review?(bzbarsky)
Attachment #468220 - Flags: review?(bzbarsky)
Attachment #468221 - Attachment is obsolete: true
Attachment #518273 - Flags: review?(bzbarsky)
Attachment #468221 - Flags: review?(bzbarsky)
Attachment #468222 - Attachment is obsolete: true
Attachment #518274 - Flags: review?(bzbarsky)
Attachment #468222 - Flags: review?(bzbarsky)
Attachment #468223 - Attachment is obsolete: true
Attachment #518275 - Flags: review?(bzbarsky)
Attachment #468223 - Flags: review?(bzbarsky)
Attachment #468224 - Attachment is obsolete: true
Attachment #518276 - Flags: review?(bzbarsky)
Attachment #468224 - Flags: review?(bzbarsky)
Attachment #468225 - Attachment is obsolete: true
Attachment #518277 - Flags: review?(bzbarsky)
Attachment #468225 - Flags: review?(bzbarsky)
Comment on attachment 518272 [details] [diff] [review]
Part 1: Rename CSSStyleRuleImpl updated to use namespace

r=me
Attachment #518272 - Flags: review?(bzbarsky) → review+
Comment on attachment 518273 [details] [diff] [review]
Part 2: rename DOMCSSStyleRuleImpl updated to use namespace.

r=me
Attachment #518273 - Flags: review?(bzbarsky) → review+
Comment on attachment 518274 [details] [diff] [review]
Part 3: Rename CSSImportantRule updated to use namespace

r=me
Attachment #518274 - Flags: review?(bzbarsky) → review+
Comment on attachment 518276 [details] [diff] [review]
Part 5: Remove virtual from methods that came from nsICSSStyleRule

r=me
Attachment #518276 - Flags: review?(bzbarsky) → review+
Comment on attachment 518277 [details] [diff] [review]
Part 6: DeCOMtaminate StyleRule method signatures

r=me
Attachment #518277 - Flags: review?(bzbarsky) → review+
Comment on attachment 518275 [details] [diff] [review]
Part 4: Remove nsICSSStyleRule and move StyleRule to header file.

r=me
Attachment #518275 - Flags: review?(bzbarsky) → review+
Duplicate of this bug: 604596
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.