576960 - Window contents offset by 1px (was: New Title Bar doesn't respect system settings)

Status: REOPENED

(Core :: Widget: Win32, defect, P4)

Description

[Tiago Sá]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100705 Minefield/4.0b2pre

This is a pretty obvious bug already for the default user, I must say, but here's what it is: the title bar doesn't respect the system defined size. I believe Windows 7 default configuration is 21, and Firefox 3.6 displays a 21 pixel high title bar, as normal. But Firefox 4.0b2pre displays it at 17 pixels high. Now, not only is this not in conformity with Shorlander's mockups, but it becomes a serious problem if you a value higher than that. It not only looks even more out of place than before, but it also looks very very ugly, and potentially nonfunctional. I will upload a screenshot right away, in a comment.

I don't know how to fix this, but I'm guessing we should just respect the system setting and go home with it. Both Opera and Chrome do about as big a mess as Minefield in this, but Minefield is more problematic since we have, by default, buttons on the right side of the tab strip.

And considering Shorlander's mockups are totally reasonable and system integrated, it shouldn't be hard to respect the system setting.

Please, don't butcher the title bar. Leave it alone, cause it's best for all.

Reproducible: Always

Comment 1

[Tiago Sá]

Attachment: Screenshot of a 35px high title bar

Here's the screenshot. As you can see, it's very VERY bad. If Firefox 4.0 final does this, it means the only proper browser for people with non-default title bar sizes is, what, IE?

Comment 2

[Jim Mathies [:jimm]]

Since we extend the client area all the way up to the top of the window, we'd need to deal with this via content. Bug 574454 maybe be able to address this through the new moz-appearance css styles.

Comment 3

[Jim Mathies [:jimm]]

Fixed by landing in bug 575870 & bug 574454.

Comment 4

[Tiago Sá]

Attachment: Screenshot of how it hasn't been fixed yet.

No, it wasn't fixed. The title bar still doesn't respect system settings. It's not just a little bit bigger (taller), but it doesn't change according to system settings.

To be noted that we should, I believe, set a minimum height for the title bar, to make sure there's no overlapping between tabs (and other stuff) and the Firefox button.

Comment 5

[redsign]

You have to restart Minefield then it will respect your setting for the title bar. I just wanted to post the same comment here till I realized that I just have to restart the browser after changing the setting for the title bar height. No need to reopen this one, imho.

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> You have to restart Minefield then it will respect your setting for the title
> bar. I just wanted to post the same comment here till I realized that I just
> have to restart the browser after changing the setting for the title bar
> height. No need to reopen this one, imho.

It would be nice to support smooth refresh when changes are made. I'll file a new bug.

Comment 7

[Jim Mathies [:jimm]]

filed bug 585964

Comment 8

[Tiago Sá]

Sorry about that. It didn't occur to me that we'd need to restart Firefox. Thanks for fixeding it again.

By the way, are there any plans to allow a title bar smaller than 23 or whatever that is? It's a bit too far away between the firefox button and the tabs, even if you set the title bar to 17 or something like that.

Comment 9

[Jim Mathies [:jimm]]

(In reply to comment #8)
> Sorry about that. It didn't occur to me that we'd need to restart Firefox.
> Thanks for fixeding it again.
> 
> By the way, are there any plans to allow a title bar smaller than 23 or
> whatever that is? It's a bit too far away between the firefox button and the
> tabs, even if you set the title bar to 17 or something like that.

Not sure. Now that we have support for system defaults, I imagine ux folks will go over how things stand and make adjustments. bug 574681 might be an appropriate place to post suggestions and screenshots.

Comment 10

[Tiago Sá]

So, where do Jim? Is this (the reopening) because the current iteration doesn't support heights bellow 23px?

Comment 11

[Tiago Sá]

With the latest nigthly, I noticed that Minefield no adjust the title bar down to 17px at least, which is great (previously it only went down to 23px, I believe, bellow that, it wouldn't get any smaller), but I did noticed that the title bar (judging from the menu bar, when it's visible using ALT) is 1px too tall, always. So if you set the system to have 19px high title bar, Firefox's will be 20px. Should I (we?) file a new bug for this, or does this need to be reopened again?

Comment 12

[Tiago Sá]

I should add that this also happens in maximized state. Actually, it's easier to check in maximized state. You just:

1. open an application with a menu bar. Firefox 3.6.8 will do
2. open Minefield
3. maximize both windows
4. in Minefield, hide the menu bar
5. press ALT
6. put your mouse cursor in a way that you know where the menu bar is supposed to be (like, right bellow the File word or something) and leave it there
7. ALT+TAB into the other window, and see that Minefield's menu bar is 1px too high

Comment 13

[Jim Mathies [:jimm]]

Attachment: compare

Looks ok here. If you can put together a screenshot showing the issue it might help.

Comment 14

[Tiago Sá]

Attachment: Screenshot of 1px too high titlebar after 575870 landed

Here's what I'm seeing. It's very minor, it's just one pixel after all, but it's there. And it's, for all means and purposes, wasted vertical space. More relevant to this topic, it's proof that it still doesn't respect system settings, because it's always 1px too high).

Thanks for looking after this Jim :)

Comment 15

[Tiago Sá]

Reading the comments on bug 574681, I think the general idea is that the final product won't have a title bar as high as the system defined bar. So maybe this bug doesn't need reopening and all the work can be done there?

My suggestion is that we make the title bar be equal to system setting -5, instead of system setting +1 as we have now. That way it will match the mockups just fine, and will be integrated with the system. I'll post a semi-duplicate of this comment there.

Comment 16

[Jim Mathies [:jimm]]

(In reply to comment #15)
> Reading the comments on bug 574681, I think the general idea is that the final
> product won't have a title bar as high as the system defined bar. So maybe this
> bug doesn't need reopening and all the work can be done there?
> 
> My suggestion is that we make the title bar be equal to system setting -5,
> instead of system setting +1 as we have now. That way it will match the mockups
> just fine, and will be integrated with the system. I'll post a semi-duplicate
> of this comment there.

Well, not sure if that would work. the titlebar is the default system titlebar when the menubar is enabled, yet the whole window (including the system drawn icon and title text) is pushed down 1px compared to 3.6. Seems like some sort of a widget bug related to the titlebar landing, but I'm not sure where.

Comment 17

[Jim Mathies [:jimm]]

reopening till we investigate the cause. not a blocker though.

Comment 18

[sunnybunny8920]

[Tracking Requested - why for this release]: