576991 - file picker does not open file picker dialog

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[info]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; en-US; rv:2.0b2pre) Gecko/20100705 Minefield/4.0b2pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; en-US; rv:2.0b2pre) Gecko/20100705 Minefield/4.0b2pre

Since either today or yesterday, when using Minefield-beta, clicking on an input type=file button (or inside the accompanying filename input) does not open a file picker dialog anymore.
This seems only the case when the config setting ui.allow_platform_file_picker is set to false.
When the config is set to true, I get the Gtk-based file picker.
Prior to yesterday it used to work correctly.


Reproducible: Always

Steps to Reproduce:
1. make sure the config setting ui.allow_platform_file_picker is set to false
2. click on the input-type=file Browse... button (or inside the accompanying input)
3.
Actual Results:  
No dialog is shown

Expected Results:  
I hoped to see a file picker dialog..

Comment 1

[Alexey Gladkov]

Attachment: nsFilePicker fix [Checkin: comment 4]

This patch fix this error.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 456347 [details] [diff] [review]
nsFilePicker fix [Checkin: comment 4]

r=bzbarsky

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 456347 [details] [diff] [review]
nsFilePicker fix [Checkin: comment 4]

http://hg.mozilla.org/mozilla-central/rev/9a924c95c6dd

Comment 5

[Benjamin Smedberg]

Why was the GTK ifdef removed from nsFilePicker.js.in? It was there on purpose, and should only be used for platforms where there isn't a native picker. This caused bug 579765.

Comment 6

[Alexey Gladkov]

This is my mistake. I commented it already in #579765 and maked a patch, but you faster.