577004 - Better labels for pin/unpin app tabs context menu items

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Johnathan Nightingale [:johnath]]

Filed as a follow up to bug 574487. I put some default context menu items in place to give us a UI for pinning/unpinning app tabs, but I can readily believe that better words exist. We should also make sure we're happy with the context menu placement. Right now it's near "Open in new Window" because I think it's a similar "Control the modality of this tab" decision, but we have a whole UX team who might disagree with me!

Comment 1

[Johnathan Nightingale [:johnath]]

Limi - faaborg says you're on point for app tabs. What would we like the context menus to actually say, and where should the entries appear?

Comment 2

[David Naylor]

How about "Pin as App Tab", and make it a checked/unchecked depending on the tab state.

Or if the App Tab name isn't set in stone, simply "Pin this tab".

Part of me feels like the App Tab name is trying to make this feature into more than it really is. Isn't pin/unpin a more honest (and understandable) lingo?

Comment 3

[Tan Wei Lin Jason [:Ryuji]]

I believe that Pinning into app Tab need a keyboard shortcut.

Comment 4

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #2)
> How about "Pin as App Tab", and make it a checked/unchecked depending on the
> tab state.

I think that's a great way to phrase it. 

Ship it! ;)

Comment 5

[Sid]

IMHO it should be simply "Pin Tab" and "Unpin Tab".

The main _visible_ feature of those tabs is that they stay alive between different browser sessions. They are almost literally "pinned" to the tab bar, so why invent things like "App Tab"? Besides, it's not necessary Web application that can be pinned into such a tab, any web page can be pinned, therefore no need for "App".

Also please think of localizability. "App Tab" may be a good neologism in English, but it's difficult to translate it adequately. I can not speak for all languages, of course, but in Russian it is very so.

Comment 6

[Alex Limi (:limi) — Firefox UX Team]

They are also intended to be global (present in all windows or tab sets), so that's one area where the "application" part comes in. And more things (think notifications, custom toolbars, etc) in the future.

Comment 7

[Tim Babych]

Thinking of how to translate "App Tab" in Ukrainian, one idea surfaced:
taking the meaning of "App" as "an app is often a self-contained environment for performing some well-defined task" we (Ukrainian l10n team) found that "Purposed Tab"(Цільова) describes the thing pretty well. "Purposed" distinguishes it from other tabs, and explains why it may be different inside - it is not the general tab, but a tab that is tailored for some specific task/site.

Hope that helps other localizers.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

For the final string (en-us) we should use comment #2, "Pin as App Tab" in the future it will be possible to have unpinned App Tabs.  Confirmed with Limi on irc just now (and in comment #4 awhile ago).

Localizers should try to capture both concepts: pinning it, and it also having different privileges (self-contained environment for performing some well-defined task).

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

Action should just be "Unpin tab" (we don't need to say that it will now be a "normal tab")

Comment 10

[David Naylor]

If it were a checked/unchecked option named "Pin as App Tab" I think it would be easier to find the menu item the second time, when you want to unpin it.

Comment 11

[Axel Hecht [:Pike]]

This has both [strings] and blocking2.0:final. One of the two is wrong.

Comment 12

[Johnathan Nightingale [:johnath]]

Attachment: "Pin as App Tab" and "Unpin Tab"

I assert that this already has ui-r

Comment 13

[Dão Gottwald [:dao]]

We'll probably need to change the entity names.

Comment 14

[Johnathan Nightingale [:johnath]]

Yeah, I wondered about that. I guess this represents a semantic change, though perversely it now more closely matches the entity names that were used all along. Axel - make the call?

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 474032 [details] [diff] [review]
"Pin as App Tab" and "Unpin Tab"

I think we need to change them. An L10N note that clarifies the meaning of "pin" in this context wouldn't hurt, either.

Comment 16

[Johnathan Nightingale [:johnath]]

Attachment: Rev entities

Carrying over reviews.

Comment 17

[Johnathan Nightingale [:johnath]]

I'll land it or mark it checkin needed once this build finishes and I'm convinced I didn't screw up an entity name somewhere.

Comment 18

[Tan Wei Lin Jason [:Ryuji]]

Pin sound weird... "Create App Tab/Remove App Tab" would sound better. But well that's my personal opinion. Pin App Tab is good but Unpin Tab sound misleading as there is no Unpin App Tab around in Firefox 4.

Comment 19

[Johnathan Nightingale [:johnath]]

Attachment: Now with localization note

Sorry for the churn.

Comment 20

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/e522e8bf3524

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 474078 [details] [diff] [review]
Now with localization note

Thanks, note is looking good.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6pre) Gecko/20100911 Firefox/4.0b6pre. Have to update some of our manual tests for context menus on Litmus.

Comment 23

[Marcia Knous [:marcia]]

I have updated https://litmus.mozilla.org/show_test.cgi?id=10010, as well as all other testcases in Litmus that reference App Tab in any way.