577039 - App Tabs: Tweak Appearance to Match Mockups

Status: RESOLVED DUPLICATE of bug 579683

(Firefox :: Theme, defect)

Description

[ronin.achilles]

User-Agent:       Mozilla/5.0(Windows; U; Windows NT 5.2; rv:1.9.2) Gecko/20100101 Firefox/3.6
Build Identifier: Mozilla/5.0(Windows; U; Windows NT 5.2; rv:1.9.2) Gecko/20100101 Firefox/3.6

Currently the App Tabs:
- Are too narrow
- The icon is not properly aligned to the icons on other Tabs...

Need a CSS fix.. something along the lines of:

.tabbrowser-tab[pinned] 
{
min-width: 36px !important;
max-width: 36px !important;
max-height: 19px !important;
}

.tabbrowser-tab[pinned] .tab-icon-image
{
margin-left: 4px !important;
margin-top: 2px !important;
}

Reproducible: Always

Comment 1

[[not reading bugmail]]

I think max-height would be better at 21px instead of the 19px here.

Here is mac theme sample:
https://wiki.mozilla.org/User:Tro/Firefox_4.0_Mac_Theme_Mockups#App-Tab_Example

Comment 2

[Gary [:streetwolf52]]

There seems to be a height inconsistency between app and normal tabs. Depending on the combination you have the tabstrip will jump up or down as you go between the two tabs.  

IMO the app tab should behave just like a normal tab in look and not make things jump around.

Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre) Gecko/20100705 Minefield/4.0b2pre - Build ID: 20100705123310

Comment 3

[imradyurrad]

Anybody have a windows mockup of how they're supposed to look?

Comment 4

[[not reading bugmail]]

Should be something like comment 1, I believe is is also a windows mockup around too showing it on the windows side, but they are pretty much the same if I recall.

Comment 5

[imradyurrad]

(In reply to comment #4)
> Should be something like comment 1, I believe is is also a windows mockup
> around too showing it on the windows side, but they are pretty much the same if
> I recall.

Shouldn't they ideally be styled like the hometab?
https://wiki.mozilla.org/images/1/17/Firefox-4-Mockup-i06-%28Win7%29-%28Aero%29-%28TabsTop%29.png

If so, this can't land before Bug 560507

Comment 7

[Dietrich Ayala (:dietrich)]

bug 579373 is the linux edition of this bug. let's keep this one to windows, since that's what the reporter is reporting.

1. can someone (reporter, or anyone) turn the code in comment #0 into a patch?

2. can someone attach screenshots of how it looks currently, and then with the suggested changes?

Comment 8

[Peter Henkel [:Terepin]]

(In reply to comment #2)
> There seems to be a height inconsistency between app and normal tabs.

There is no such thing.

(In reply to comment #3)
> Anybody have a windows mockup of how they're supposed to look?

The same is in Mac and in Linux.

(In reply to comment #5)
> Shouldn't they ideally be styled like the hometab?

Yes.

For all: AppTabs will look just like Home Tab and New Tab. Nothing special.

Comment 9

[Dão Gottwald [:dao]]

> Currently the App Tabs:
> - Are too narrow

bug 587576

> - The icon is not properly aligned to the icons on other Tabs...

bug 579683

In general, please file concrete bugs on concrete issues rather than "tweak foo to match mockups".